X Tutup
Skip to content

Apply IDE0019: InlineAsTypeCheck in Microsoft.Management #19687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
May 24, 2023
Merged

Apply IDE0019: InlineAsTypeCheck in Microsoft.Management #19687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimAsyncOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,16 +344,14 @@ protected virtual void SubscribeToCimSessionProxyEvent(CimSessionProxy proxy)
/// <returns></returns>
protected object GetBaseObject(object value)
{
PSObject psObject = value as PSObject;
if (psObject == null)
if (value is not PSObject psObject)
{
return value;
}
else
{
object baseObject = psObject.BaseObject;
var arrayObject = baseObject as object[];
if (arrayObject == null)
if (baseObject is not object[] arrayObject)
{
return baseObject;
}
Expand All @@ -380,8 +378,7 @@ protected object GetBaseObject(object value)
/// <returns>The object.</returns>
protected object GetReferenceOrReferenceArrayObject(object value, ref CimType referenceType)
{
PSReference cimReference = value as PSReference;
if (cimReference != null)
if (value is PSReference cimReference)
{
object baseObject = GetBaseObject(cimReference.Value);
if (!(baseObject is CimInstance cimInstance))
Expand All @@ -394,8 +391,7 @@ protected object GetReferenceOrReferenceArrayObject(object value, ref CimType re
}
else
{
object[] cimReferenceArray = value as object[];
if (cimReferenceArray == null)
if (value is not object[] cimReferenceArray)
{
return null;
}
Expand Down
6 changes: 2 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,7 @@ protected static string GetQuery(CimBaseCommand cmdlet)
internal static bool IsClassNameQuerySet(CimBaseCommand cmdlet)
{
DebugHelper.WriteLogEx();
GetCimInstanceCommand cmd = cmdlet as GetCimInstanceCommand;
if (cmd != null)
if (cmdlet is GetCimInstanceCommand cmd)
{
if (cmd.QueryDialect != null || cmd.SelectProperties != null || cmd.Filter != null)
{
Expand All @@ -299,8 +298,7 @@ internal static bool IsClassNameQuerySet(CimBaseCommand cmdlet)
protected static string CreateQuery(CimBaseCommand cmdlet)
{
DebugHelper.WriteLogEx();
GetCimInstanceCommand cmd = cmdlet as GetCimInstanceCommand;
if (cmd != null)
if (cmdlet is GetCimInstanceCommand cmd)
{
StringBuilder propertyList = new();
if (cmd.SelectProperties == null)
Expand Down
9 changes: 3 additions & 6 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimIndicationWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,11 @@ private void NewSubscriptionResultHandler(object src, CimSubscriptionEventArgs a
if (temp != null)
{
// raise the event
CimSubscriptionResultEventArgs resultArgs = args as CimSubscriptionResultEventArgs;
if (resultArgs != null)
if (args is CimSubscriptionResultEventArgs resultArgs)
temp(this, new CimIndicationEventInstanceEventArgs(resultArgs.Result));
else
else if (args is CimSubscriptionExceptionEventArgs exceptionArgs)
{
CimSubscriptionExceptionEventArgs exceptionArgs = args as CimSubscriptionExceptionEventArgs;
if (exceptionArgs != null)
temp(this, new CimIndicationEventExceptionEventArgs(exceptionArgs.Exception));
temp(this, new CimIndicationEventExceptionEventArgs(exceptionArgs.Exception));
}
}
}
Expand Down
6 changes: 2 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimNewCimInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,7 @@ internal void GetCimInstance(CimInstance cimInstance, XOperationContextBase cont
{
DebugHelper.WriteLogEx();

CimNewCimInstanceContext newCimInstanceContext = context as CimNewCimInstanceContext;
if (newCimInstanceContext == null)
if (context is not CimNewCimInstanceContext newCimInstanceContext)
{
DebugHelper.WriteLog("Invalid (null) CimNewCimInstanceContext", 1);
return;
Expand Down Expand Up @@ -295,8 +294,7 @@ private CimInstance CreateCimInstance(

DebugHelper.WriteLog("Create and add new property to ciminstance: name = {0}; value = {1}; flags = {2}", 5, propertyName, propertyValue, flag);

PSReference cimReference = propertyValue as PSReference;
if (cimReference != null)
if (propertyValue is PSReference cimReference)
{
CimProperty newProperty = CimProperty.Create(propertyName, GetBaseObject(cimReference.Value), CimType.Reference, flag);
cimInstance.CimInstanceProperties.Add(newProperty);
Expand Down
9 changes: 3 additions & 6 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimRegisterCimIndication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,7 @@ private void CimIndicationHandler(object cimSession, CmdletActionEventArgs actio
}

// NOTES: should move after this.Disposed, but need to log the exception
CimWriteError cimWriteError = actionArgs.Action as CimWriteError;
if (cimWriteError != null)
if (actionArgs.Action is CimWriteError cimWriteError)
{
this.Exception = cimWriteError.Exception;
if (!this.ackedEvent.IsSet)
Expand All @@ -219,11 +218,9 @@ private void CimIndicationHandler(object cimSession, CmdletActionEventArgs actio
DebugHelper.WriteLog("Got an exception: {0}", 2, Exception);
}

CimWriteResultObject cimWriteResultObject = actionArgs.Action as CimWriteResultObject;
if (cimWriteResultObject != null)
if (actionArgs.Action is CimWriteResultObject cimWriteResultObject)
{
CimSubscriptionResult result = cimWriteResultObject.Result as CimSubscriptionResult;
if (result != null)
if (cimWriteResultObject.Result is CimSubscriptionResult result)
{
EventHandler<CimSubscriptionEventArgs> temp = this.OnNewSubscriptionResult;
if (temp != null)
Expand Down
6 changes: 2 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimResultObserver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,7 @@ public override void OnNext(CimMethodResultBase value)

string resultObjectPSType = null;
PSObject resultObject = null;
CimMethodResult methodResult = value as CimMethodResult;
if (methodResult != null)
if (value is CimMethodResult methodResult)
{
resultObjectPSType = PSTypeCimMethodResult;
resultObject = new PSObject();
Expand All @@ -431,8 +430,7 @@ public override void OnNext(CimMethodResultBase value)
}
else
{
CimMethodStreamedResult methodStreamedResult = value as CimMethodStreamedResult;
if (methodStreamedResult != null)
if (value is CimMethodStreamedResult methodStreamedResult)
{
resultObjectPSType = PSTypeCimMethodStreamedResult;
resultObject = new PSObject();
Expand Down
6 changes: 2 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimWriteError.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,12 @@ internal static ErrorRecord ErrorRecordFromAnyException(
{
Debug.Assert(inner != null, "Caller should verify inner != null");

CimException cimException = inner as CimException;
if (cimException != null)
if (inner is CimException cimException)
{
return CreateFromCimException(context, cimException, cimResultContext);
}

var containsErrorRecord = inner as IContainsErrorRecord;
if (containsErrorRecord != null)
if (inner is IContainsErrorRecord containsErrorRecord)
{
return InitializeErrorRecord(context,
exception: inner,
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CmdletOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ public override void WriteObject(object sendToPipeline, XOperationContextBase co

if (sendToPipeline is CimInstance)
{
CimSetCimInstanceContext setContext = context as CimSetCimInstanceContext;
if (setContext != null)
if (context is CimSetCimInstanceContext setContext)
{
if (string.Equals(setContext.ParameterSetName, CimBaseCommand.QueryComputerSet, StringComparison.OrdinalIgnoreCase) ||
string.Equals(setContext.ParameterSetName, CimBaseCommand.QuerySessionSet, StringComparison.OrdinalIgnoreCase))
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,7 @@ internal void BuildSessionOptions(out CimSessionOptions outputOptions, out CimCr
outputCredential = null;
if (options != null)
{
DComSessionOptions dcomOptions = options as DComSessionOptions;
if (dcomOptions != null)
if (options is DComSessionOptions dcomOptions)
{
bool conflict = false;
string parameterName = string.Empty;
Expand Down
X Tutup