Add WDAC Audit logging 3#19641
Conversation
…-Object.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…-Object.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…nd.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
daxian-dbw
left a comment
There was a problem hiding this comment.
Looks good to me overall. Left a few more comments.
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/client/RunspaceRef.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Operations/MiscOps.cs
Outdated
Show resolved
Hide resolved
…cOps.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM. Thanks @PaulHigin for pushing this change through!
|
🎉 Handy links: |
PR Summary
This PR adds WDAC audit logging using a different implementation from previous versions.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).