Harden 'All approved Cmdlets present' test #19530
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Apr 20, 2023
Merged
Harden 'All approved Cmdlets present' test #19530adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
Change logic for comparing approved cmdlet list.
daxian-dbw
requested changes
Apr 19, 2023
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Show resolved
Hide resolved
This reverts commit b3d7bcd.
daxian-dbw
approved these changes
Apr 20, 2023
adityapatwardhan
approved these changes
Apr 20, 2023
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change logic for comparing approved cmdlet list.
PR Context
This test has been failing in our release tests. This attempts to get it to pass in both CI and release builds.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).