Fix wildcard globbing in root of device paths#19442
Fix wildcard globbing in root of device paths#19442daxian-dbw merged 6 commits intoPowerShell:masterfrom
Conversation
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
TravisEz13
left a comment
There was a problem hiding this comment.
reviewed for previous issues I've seen in globbing
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@SteveL-MSFT So the bugs you found are out of scope of the changes in this PR? |
|
@daxian-dbw the bugs were not due to this PR and should be addressed separately |
|
🎉 Handy links: |
PR Summary
Fixes scenarios like:
Get-ChildItem -Path '\\.\C:\*'so it properly handles wildcards at the root.The code would find the parent of the wildcard (in this case
\\.\C:\) but it would leave out the trailing separator (so it would end up like this:\\.\C:) which is not valid for device path roots.This PR adds a check for root device paths and adds back the missing backslash if needed.
PR Context
Fixes #19439
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).