X Tutup
Skip to content

Enable type conversion of AutomationNull to $null for assignment #19415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
Apr 3, 2023
Merged

Enable type conversion of AutomationNull to $null for assignment #19415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07147aa
Enable type conversion of AutomationNull to $null for property assign…
SteveL-MSFT Mar 27, 2023
9456841
remove unnecessary quotes
SteveL-MSFT Mar 27, 2023
9175168
fix codefactor
SteveL-MSFT Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/System.Management.Automation/engine/LanguagePrimitives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4691,6 +4691,12 @@ internal static PSObject SetObjectProperties(object o, IDictionary properties, T
}
}

// treat AutomationNull.Value as null for consistency
if (propValue == AutomationNull.Value)
{
propValue = null;
}

property.Value = propValue;
}
else
Expand Down
12 changes: 12 additions & 0 deletions test/powershell/Language/Scripting/Scripting.Followup.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ Describe "Scripting.Followup.Tests" -Tags "CI" {
$arraylist.Count | Should -Be 0
}

It 'AutomationNull should be same as null for type conversion' {
$result = pwsh -noprofile -command {
class Example {
[string[]]$LogMessage
}

[Example] @{ LogMessage = [System.Management.Automation.Internal.AutomationNull]::Value }
}

$result.LogMessage | Should -BeNullOrEmpty
}

## fix https://github.com/PowerShell/PowerShell/issues/17165
It "([bool] `$var = 42) should return the varaible value" {
([bool]$var = 42).GetType().FullName | Should -Be "System.Boolean"
Expand Down
X Tutup