X Tutup
Skip to content

Fix codefactor if part 1#19266

Merged
iSazonov merged 5 commits intoPowerShell:masterfrom
CarloToso:fix-codefactor-if-part-1
Mar 3, 2023
Merged

Fix codefactor if part 1#19266
iSazonov merged 5 commits intoPowerShell:masterfrom
CarloToso:fix-codefactor-if-part-1

Conversation

@CarloToso
Copy link
Copy Markdown
Contributor

@CarloToso CarloToso commented Mar 2, 2023 •
edited by iSazonov
Loading

PR Summary

Fix codefactor errors with if
around 25 files for every PR

Regex: if\s\(.*;

PR Context

PR Checklist

@ghost ghost assigned anmenaga Mar 2, 2023
This was referenced Mar 2, 2023
Merged
Merged
Merged
iSazonov
iSazonov reviewed Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to turn on Roslyn analyzer rule. After that we could use dotnet format to apply auto fixes for code.

src/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs
{
output.Write(", ");
}
firstParameterSet = false;
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our code guidance is to have blank line after }.
I'd prefer we turn on Roslyn analyzer rule for this in follow PR.

Copy link
Copy Markdown
Contributor Author

@CarloToso CarloToso Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Mar 3, 2023

This PR has 203 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +135 -68
Percentile : 60.3%

Total files changed: 25

Change summary by file extension:
.cs : +135 -68

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Mar 3, 2023
@iSazonov iSazonov merged commit d004076 into PowerShell:master Mar 3, 2023
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Mar 3, 2023
@CarloToso CarloToso deleted the fix-codefactor-if-part-1 branch March 7, 2023 18:44
@CarloToso CarloToso mentioned this pull request Mar 7, 2023
Merged
22 tasks
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarloToso @iSazonov @anmenaga
X Tutup