Replace BitConverter.ToString(bytes).Replace("-", "") with Convert.ToHexString(bytes)#19216
Conversation
|
@turbedi I found one more string payLoadData = Convert.ToHexString(fragmentData.blob, fragmentData.offset, fragmentData.length);
payLoadData = string.Create(CultureInfo.InvariantCulture, $"0x{payLoadData}");
|
Co-Authored-By: CarloToso <105941898+CarloToso@users.noreply.github.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Good catch, fixed.
|
|
🎉 Handy links: |
PR Summary
Replace BitConverter.ToString(bytes).Replace("-", "") with Convert.ToHexString(bytes) which is more performant and saves allocations.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).