Fix array type parsing in generic types#19205
Conversation
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@daxian-dbw @SeeminglyScience Friendly ping. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Thanks @MartinGC94 for the contribution! |
|
🎉 Handy links: |
PR Summary
Fixes the generic type argument parsing so array types don't need additional brackets to be parsed correctly.
So now this:
[System.Tuple[System.String[],System.Int32[]]]works like you would expect.The issue was caused by the parser looking for an assembly qualified name if a comma appeared after an array type, but that's not valid inside unbracketed generic type arguments so a check has been added for that.
PR Context
Fixes #18686
Fixes #9639
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).