X Tutup
Skip to content

Speed up Resolve-Path relative path resolution#19171

Merged
iSazonov merged 2 commits intoPowerShell:masterfrom
MartinGC94:SpeedUpResolvePathCmd
Mar 15, 2023
Merged

Speed up Resolve-Path relative path resolution#19171
iSazonov merged 2 commits intoPowerShell:masterfrom
MartinGC94:SpeedUpResolvePathCmd

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

@MartinGC94 MartinGC94 commented Feb 17, 2023

PR Summary

Improves the performance of Resolve-Path relative when resolving multiple paths in the same directory, for example when using it like this: Resolve-Path -Path C:\Windows\System32\* -Relative
This is done by saving the resolved base path and reusing it every time a new item in the same directory is encountered.

On my system Measure-Command -Expression {Resolve-Path -Path C:\Windows\System32\* -Relative} takes 1 second and 200 ms on average without this fix, and around 90ms with this fix.

PR Context

PR Checklist

@ghost ghost assigned iSazonov Feb 17, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Feb 25, 2023
@ghost
Copy link
Copy Markdown

ghost commented Feb 25, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Feb 27, 2023

I watched it several times and each time I came back to the idea that it was too tricky for such a limited scenario. It would be much more useful to improve NormalizeRelativePath itself - in implementation and/or on API level.

@ghost ghost removed the Review - Needed The PR is being reviewed label Feb 27, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Mar 7, 2023
@ghost
Copy link
Copy Markdown

ghost commented Mar 7, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Mar 14, 2023

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +10 -0
Percentile : 4%

Total files changed: 1

Change summary by file extension:
.cs : +10 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw
daxian-dbw approved these changes Mar 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log and removed Review - Needed The PR is being reviewed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Mar 14, 2023
@iSazonov iSazonov merged commit 8b964de into PowerShell:master Mar 15, 2023
@MartinGC94 MartinGC94 deleted the SpeedUpResolvePathCmd branch March 15, 2023 14:57
@ghost
Copy link
Copy Markdown

ghost commented Apr 20, 2023

🎉v7.4.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@iSazonov iSazonov

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinGC94 @iSazonov @daxian-dbw
X Tutup