Small changes in Webcmdlets by CarloToso · Pull Request #19109 · PowerShell/PowerShell

CarloToso · 2023-02-06T15:03:02Z

PR Summary

Certificate store was opened but never closed -> using store
I think we don't need to use GetHttpClient(handleRedirect) twice, the client doesn't change
Formatting

PR Context

PR Checklist

iSazonov · 2023-02-06T18:00:08Z

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

                    currentUri = new Uri(request.RequestUri, response.Headers.Location);
+
                    // Continue to handle redirection
-                    using (client = GetHttpClient(handleRedirect))


Good step for #12764 (comment) You could continue...

I will try to continue, can you give me a more detailed to-do list?

I laid out there already. The goal is to cache HttpClient/HttpClientHandler in WebSession. These HttpClient/HttpClientHandler cannot be changed after they start. So if a cmdlet is called with modified arguments when there is a WebSession, we have to recreate them. This makes me think that our first step is to move all initialization to BeginProcessing. If it's possible, we can then implement caching.

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

iSazonov · 2023-02-07T09:16:44Z

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

-                        response = GetResponse(client, redirectRequest, handleRedirect);
-                    }
+                    using HttpRequestMessage redirectRequest = GetRequest(currentUri);
+                    response = GetResponse(client, redirectRequest, handleRedirect);


Nit: it would great to inspect how we dispose HttpResponseMessage

I noticed that:

response = GetResponse(client, redirectRequest, handleRedirect); line 1275

return GetResponse(client, requestWithoutRange, handleRedirect); line 1309
are doing the same thing, I think they should have similar formatting, which one is better?

To dispose of HttpResponseMessage we could add using on line 1422, and it might be enough

I don't understand the question about formatting.

To dispose of HttpResponseMessage we could add using on line 1422

Yes. And I see two callsites return GetResponse - I guess we need to dispose previous response before return new one.

In follow PR please.

I'm sorry, I meant they should have the same syntax (not formatting) . And I wanted to know which syntax was more clear. In the next PR

I still don't understand. Feel free to pull PR with your preference.

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

pull-request-quantifier-deprecated · 2023-02-08T09:52:07Z

This PR has 21 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +8 -13
Percentile : 8.4%

Total files changed: 1

Change summary by file extension:
.cs : +8 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

ghost · 2023-03-14T22:25:49Z

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

CarloToso added 5 commits February 6, 2023 14:00

close certificate store

5d8a59c

don't GetHttpClient when handleRedirect

aa772c2

var -> Uri

942bd83

remove req.Dispose()

1dd7c11

add newline before comments

17ddd3f

CarloToso requested a review from PaulHigin as a code owner February 6, 2023 15:03

pull-request-quantifier-deprecated bot added the Extra Small label Feb 6, 2023

ghost assigned daxian-dbw Feb 6, 2023

iSazonov reviewed Feb 6, 2023

View reviewed changes

iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 6, 2023

CarloToso added 7 commits February 6, 2023 21:28

using StreamReader

6aed56d

using X509Store store

73fdf35

follow suggestion

787e467

using remove () {}

f917579

use ternary operator

f764dd8

use ternary

b8bb05a

comment

71c02b7

iSazonov reviewed Feb 7, 2023

View reviewed changes

revert

83deb26

iSazonov reviewed Feb 7, 2023

View reviewed changes

using StreamReader reader

1a8fcda

iSazonov reviewed Feb 8, 2023

View reviewed changes

...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs Outdated Show resolved Hide resolved

revert reader

e2f20be

CarloToso mentioned this pull request Feb 8, 2023

Dispose previous response in Webcmdlets #19117

Merged

22 tasks

iSazonov approved these changes Feb 8, 2023

View reviewed changes

iSazonov closed this Feb 8, 2023

iSazonov reopened this Feb 8, 2023

iSazonov changed the title ~~Small changes webcmdlets~~ Small changes in Webcmdlets Feb 8, 2023

iSazonov merged commit 462f825 into PowerShell:master Feb 8, 2023

CarloToso deleted the small-changes-webcmdlets branch February 8, 2023 10:56

iSazonov assigned iSazonov and unassigned daxian-dbw Feb 8, 2023

stevenebutler mentioned this pull request Feb 14, 2023

PS 6/7 are 4-5x slower than PS 5 due to not using web connection pool #12764

Closed

Conversation

CarloToso commented Feb 6, 2023 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

CarloToso Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

iSazonov Feb 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iSazonov Feb 7, 2023

Choose a reason for hiding this comment

Uh oh!

CarloToso Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CarloToso Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

iSazonov Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pull-request-quantifier-deprecated bot commented Feb 8, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

ghost commented Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CarloToso commented Feb 6, 2023 •

edited by iSazonov

Loading

CarloToso Feb 7, 2023 •

edited

Loading

iSazonov Feb 8, 2023 •

edited

Loading

iSazonov Feb 8, 2023 •

edited

Loading