X Tutup
Skip to content

Build the relative URI for links from the response in Invoke-WebRequest#19092

Merged
iSazonov merged 9 commits intoPowerShell:masterfrom
CarloToso:FollowRelLink-use-the-URI-resolved-in-response.RequestMessage.RequestUri
Feb 10, 2023
Merged

Build the relative URI for links from the response in Invoke-WebRequest#19092
iSazonov merged 9 commits intoPowerShell:masterfrom
CarloToso:FollowRelLink-use-the-URI-resolved-in-response.RequestMessage.RequestUri

Conversation

@CarloToso
Copy link
Copy Markdown
Contributor

@CarloToso CarloToso commented Feb 2, 2023 •
edited by iSazonov
Loading

PR Summary

Ignore the user provided uri and use the URI resolved in response.RequestMessage.RequestUri

PR Context

Fix #8935 proposed by @markekraus

PR Checklist

@CarloToso CarloToso requested a review from PaulHigin as a code owner February 2, 2023 23:09
@ghost ghost assigned daxian-dbw Feb 2, 2023
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Feb 3, 2023

@CarloToso Please add new test.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 3, 2023
iSazonov
iSazonov reviewed Feb 3, 2023
View reviewed changes
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Feb 10, 2023

/home/vsts/work/1/s/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs(1423,1): error SA1507: Code should not contain multiple blank lines in a row [/home/vsts/work/1/s/src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj]

iSazonov
iSazonov reviewed Feb 10, 2023
View reviewed changes
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs Outdated
return bodyBuilder.ToString();
}


Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Feb 10, 2023
iSazonov
iSazonov requested changes Feb 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarloToso Please look CI fails on Windows.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2023
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Feb 10, 2023

This PR has 25 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +17 -8
Percentile : 10%

Total files changed: 2

Change summary by file extension:
.cs : +5 -4
.ps1 : +12 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@CarloToso
Copy link
Copy Markdown
Contributor Author

CarloToso commented Feb 10, 2023

@iSazonov it seem it was an unrelated error

@iSazonov iSazonov changed the title Invoke-WebRequest ParseLinkHeader requestUri from response Build the relative URI for links from the response in Invoke-WebRequest Feb 10, 2023
@iSazonov iSazonov merged commit 2f43013 into PowerShell:master Feb 10, 2023
@CarloToso CarloToso deleted the FollowRelLink-use-the-URI-resolved-in-response.RequestMessage.RequestUri branch February 10, 2023 16:50
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invoke-WebRequest resolves host names (URIs without http:// or https://) inconsistently

3 participants

@CarloToso @iSazonov @daxian-dbw
X Tutup