X Tutup
Skip to content

Use interpolated strings 6#18983

Merged
iSazonov merged 6 commits intoPowerShell:masterfrom
CarloToso:Use-interpolated-strings-split-6
Jan 20, 2023
Merged

Use interpolated strings 6#18983
iSazonov merged 6 commits intoPowerShell:masterfrom
CarloToso:Use-interpolated-strings-split-6

Conversation

@CarloToso
Copy link
Copy Markdown
Contributor

@CarloToso CarloToso commented Jan 19, 2023 •
edited by iSazonov
Loading

PR Summary

Replace string.Format() with new string.Create((IFormatProvider? provider, [InterpolatedStringHandlerArgument(nameof(provider))] ref DefaultInterpolatedStringHandler handler).

PR Context

#18974

PR Checklist

@ghost ghost assigned anmenaga Jan 19, 2023
@iSazonov iSazonov closed this Jan 20, 2023
@iSazonov iSazonov reopened this Jan 20, 2023
@iSazonov iSazonov added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Jan 20, 2023
iSazonov
iSazonov requested changes Jan 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarloToso We should use
StringBuilder.Append() instead of StringBuilder.AppendFormat(). Earlier I pointed out to you the wrong method.

Please look Use interpolated strings 8 and Use interpolated strings 7 too.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 20, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 20, 2023
iSazonov
iSazonov reviewed Jan 20, 2023
View reviewed changes
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Jan 20, 2023

This PR has 139 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +55 -84
Percentile : 47.8%

Total files changed: 17

Change summary by file extension:
.cs : +55 -84

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jan 20, 2023
@iSazonov iSazonov merged commit e815e57 into PowerShell:master Jan 20, 2023
@CarloToso CarloToso deleted the Use-interpolated-strings-split-6 branch January 20, 2023 15:28
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarloToso @iSazonov @anmenaga
X Tutup