X Tutup
Skip to content

Update and enable test#18968

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
MartinGC94:RemoveUnusedTest
Mar 13, 2023
Merged

Update and enable test#18968
daxian-dbw merged 2 commits intoPowerShell:masterfrom
MartinGC94:RemoveUnusedTest

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

@MartinGC94 MartinGC94 commented Jan 18, 2023

PR Summary

Updates and enables a test now that a conclusion has been made for the related issue: #1563

PR Context

PR Checklist

@ghost ghost assigned PaulHigin Jan 18, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 26, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jan 26, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Jan 30, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 3, 2023
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 9 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -5
Percentile : 3.6%

Total files changed: 1

Change summary by file extension:
.ps1 : +4 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@MartinGC94 MartinGC94 changed the title Remove unused test Update and enable test Feb 3, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Feb 11, 2023
@ghost
Copy link
Copy Markdown

ghost commented Feb 11, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@MartinGC94 MartinGC94 requested a review from SteveL-MSFT March 2, 2023 11:24
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw dismissed SteveL-MSFT’s stale review March 13, 2023 23:16

Feedback had been addressed

@daxian-dbw daxian-dbw merged commit 799eed8 into PowerShell:master Mar 13, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 13, 2023
@daxian-dbw daxian-dbw added Review - Needed The PR is being reviewed CL-Test Indicates that a PR should be marked as a test change in the Change Log labels Mar 13, 2023
@MartinGC94 MartinGC94 deleted the RemoveUnusedTest branch March 14, 2023 05:25
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Small Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup