X Tutup
Skip to content

Fix regression in RemoveNulls #18881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jan 10, 2023
Merged

Fix regression in RemoveNulls #18881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,22 +1910,24 @@ private char GetCharacterUnderCursor(Coordinates cursorPosition)
#endif

/// <summary>
/// Strip nulls from a string...
/// Strip nulls from a string.
/// </summary>
/// <param name="input">The string to process.</param>
/// <returns>The string with any \0 characters removed...</returns>
/// <returns>The string with any '\0' characters removed.</returns>
private static string RemoveNulls(string input)
{
if (input.Contains('\0'))
if (!input.Contains('\0'))
{
return input;
}

StringBuilder sb = new StringBuilder();
StringBuilder sb = new StringBuilder(input.Length);
foreach (char c in input)
{
if (c != '\0')
{
sb.Append(c);
}
}

return sb.ToString();
Expand Down
X Tutup