Fix regression in RemoveNulls#18881
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Is there a test that could be added?
I don't understand how the nulls could appear. Perhaps it is internals of the Windows API. Then there is no chance of creating a test. 😕 |
|
This code appears to only be used with the built in ReadLine and not when PSReadLine is used. I suspect it's to handle the case of cut & paste where the content includes nulls. Given that this code is likely not used often (as most folks are using the default PSReadLine), I wouldn't spend time adding a test then. |
|
🎉 Handy links: |
PR Summary
Fix regression after #11884.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).