X Tutup
Skip to content

Allow combining of -Skip and -SkipLast parameters in Select-Object cmdlet.#18849

Merged
TravisEz13 merged 4 commits intoPowerShell:masterfrom
ArmaanMcleod:select-object-skip-param-fix
May 2, 2023
Merged

Allow combining of -Skip and -SkipLast parameters in Select-Object cmdlet.#18849
TravisEz13 merged 4 commits intoPowerShell:masterfrom
ArmaanMcleod:select-object-skip-param-fix

Conversation

@ArmaanMcleod
Copy link
Copy Markdown
Contributor

@ArmaanMcleod ArmaanMcleod commented Dec 26, 2022 •
edited by github-actions bot
Loading

PR Summary

Fixes #11752

Modified parameter set for Skip to include SkipLastParameter parameter set.

PR Context

Allow combining of -Skip and -SkipLast when using Select-Object cmdlet.

e.g.

1, 2, 3 | Select-Object -Skip 1 -SkipLast 1
2

PR Checklist

@ghost ghost assigned TravisEz13 Dec 26, 2022
@ArmaanMcleod ArmaanMcleod changed the title Select-Object Cmdlet - Allow combining -Skip and -SkipLast parameters Select-Object Cmdlet - Allow combining of -Skip and -SkipLast parameters Dec 26, 2022
@ArmaanMcleod
Copy link
Copy Markdown
Contributor Author

ArmaanMcleod commented Dec 26, 2022

@microsoft-github-policy-service agree [company="{your company}"]

@ArmaanMcleod
Copy link
Copy Markdown
Contributor Author

ArmaanMcleod commented Dec 26, 2022

@microsoft-github-policy-service agree

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 27, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 3, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jan 3, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ArmaanMcleod ArmaanMcleod changed the title Select-Object Cmdlet - Allow combining of -Skip and -SkipLast parameters Allow combining of -Skip and -SkipLast parameters in Select-Object cmdlet. Feb 9, 2023
@daxian-dbw daxian-dbw added WG-Cmdlets general cmdlet issues Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented May 1, 2023

/remind me in 1 day

@ghost ghost removed the Review - Needed The PR is being reviewed label May 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 1, 2023

@TravisEz13 set a reminder for 5/2/2023

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 2, 2023

👋 @TravisEz13,

@github-actions github-actions bot removed the reminder label May 2, 2023
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented May 2, 2023

/remind me in 1 day

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 2, 2023

@TravisEz13 set a reminder for 5/3/2023

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented May 2, 2023

This PR has 16 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +16 -0
Percentile : 6.4%

Total files changed: 2

Change summary by file extension:
.cs : +1 -0
.ps1 : +15 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 mentioned this pull request May 2, 2023
Closed
3 tasks
@TravisEz13 TravisEz13 merged commit 07e041f into PowerShell:master May 2, 2023
@ArmaanMcleod ArmaanMcleod deleted the select-object-skip-param-fix branch May 6, 2023 09:25
@sdwheeler sdwheeler removed the Needs-Triage The issue is new and needs to be triaged by a work group. label Jun 1, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+1 more reviewer

@kilasuit kilasuit kilasuit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small reminder WG-Cmdlets general cmdlet issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Select-Object: Allow combining -Skip and -SkipLast

6 participants

@ArmaanMcleod @TravisEz13 @kilasuit @iSazonov @daxian-dbw @sdwheeler
X Tutup