X Tutup
Skip to content

Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() 2#18792

Merged
iSazonov merged 28 commits intoPowerShell:masterfrom
CarloToso:throw-new-ArgumentNullException(nameof())-2
Dec 16, 2022
Merged

Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() 2#18792
iSazonov merged 28 commits intoPowerShell:masterfrom
CarloToso:throw-new-ArgumentNullException(nameof())-2

Conversation

@CarloToso
Copy link
Copy Markdown
Contributor

@CarloToso CarloToso commented Dec 14, 2022

PR Summary

Continues #18784

8 search results for throw new ArgumentNullException(, I don't think they should be changed

PR Context

The new API ArgumentNullException.ThrowIfNull allows you to omit the parameter name, in which case it will use the name of the argument passed in. The passed in argument usually is the parameter to be validated, so that's just the right name to use when calling ArgumentNullException.ThrowIfNull(argument).

CarloToso and others added 2 commits December 14, 2022 17:22
…Help.cs

Co-authored-by: Ilya <darpa@yandex.ru>
…Help.cs

Co-authored-by: Ilya <darpa@yandex.ru>
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Dec 14, 2022

We will get ArgumentOutOfRangeException.ThrowIfZero() only with .Net 8.0 in next January.

@CarloToso
Copy link
Copy Markdown
Contributor Author

CarloToso commented Dec 14, 2022

What can I do about this build error? 'ArgumentOutOfRangeException' does not contain a definition for 'ThrowIfZero'

I'll revert waiting for .Net8.0

@CarloToso CarloToso changed the title Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() 2 [WIP]Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() 2 Dec 14, 2022
@CarloToso CarloToso changed the title [WIP]Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() 2 Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() 2 Dec 14, 2022
…ization/SessionBasedWrapper.cs

Co-authored-by: Ilya <darpa@yandex.ru>
@aung2021

This comment was marked as spam.

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 87 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +39 -48
Percentile : 34.8%

Total files changed: 26

Change summary by file extension:
.cs : +39 -48

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 16, 2022
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Dec 16, 2022
@iSazonov iSazonov merged commit b48943c into PowerShell:master Dec 16, 2022
@CarloToso CarloToso deleted the throw-new-ArgumentNullException(nameof())-2 branch December 16, 2022 20:34
{
throw new ArgumentNullException("element");
}
ArgumentNullException.ThrowIfNull(parent, nameof(element));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze The second parameter appears to be incorrect.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov suggested this change #18792 (comment)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is frozen and we should keep its behavior unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup