X Tutup
Skip to content

Fix completion for PSCustomObject variable properties#18682

Merged
daxian-dbw merged 4 commits intoPowerShell:masterfrom
MartinGC94:FixCompletionForPsObjectVarProperties
Mar 14, 2023
Merged

Fix completion for PSCustomObject variable properties#18682
daxian-dbw merged 4 commits intoPowerShell:masterfrom
MartinGC94:FixCompletionForPsObjectVarProperties

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

@MartinGC94 MartinGC94 commented Nov 30, 2022

PR Summary

Fixes tab completion scenarios like:

PS C:\> $Test = Get-ChildItem C:\ | select Name,LastWriteTime
PS C:\> $Test | where {$_.las<Tab>

Where the script text that assigns a value to the variable is unavailable so it infers the members based on the current variable value. Previously it would just show the PSObject members but now it shows the custom member values as well.

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Nov 30, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 7, 2022
@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 21, 2022
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Mar 1, 2023

This PR has 17 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +16 -1
Percentile : 6.8%

Total files changed: 2

Change summary by file extension:
.cs : +11 -1
.ps1 : +5 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw
daxian-dbw approved these changes Mar 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Mar 14, 2023

The markdown link check failure was due to the CodeCoverageAnalysis.md doc, which was already removed. So, it doesn't block this PR.

@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 14, 2023
@daxian-dbw daxian-dbw merged commit e6655d1 into PowerShell:master Mar 14, 2023
@MartinGC94 MartinGC94 deleted the FixCompletionForPsObjectVarProperties branch March 14, 2023 05:27
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MartinGC94 @daxian-dbw @iSazonov @TravisEz13
X Tutup