Conversation
src/Microsoft.PowerShell.Commands.Management/commands/management/SetClipboardCommand.cs
Outdated
Show resolved
Hide resolved
|
Failures in Windows CI do not seem related to the change - they passed before the rename suggested by @SteveL-MSFT |
|
I restarted Windows-CI. |
|
@dkaszews Please create new issue in Docs repository and add reference to it in the PR check list. |
|
@iSazonov Done |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
src/Microsoft.PowerShell.Commands.Management/commands/management/SetClipboardCommand.cs
Outdated
Show resolved
Hide resolved
|
@SteveL-MSFT Can you please review? I can remove this |
|
Sorry for the delay, I've queued this up to the Cmdlets WG to discuss |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
src/Microsoft.PowerShell.Commands.Management/commands/management/SetClipboardCommand.cs
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Sorry for the delay, the @PowerShell/wg-powershell-cmdlets agreed on the switch for this so this should be ready to merge given the PR signoffs |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Can this get merged?? |
I'd be happy to know myself, I stopped contributing to PowerShell because of ridiculous review times. It's not the only MR I have stuck in review for over 6 months. |
|
I have brought this up at the Cmdlet WG and we are happy for this to go ahead. That said, I can not do the merge. @iSazonov can you merge this PR? Also - let me know what other PRs you have that are open and if I can, I'll get them in front of the WG next week. |
|
@doctordns Thank you for driving this. For the other two PRs I have open, #18003 fixes white confirm text that is invisible on white background so unsure Cmdlet WG will care. #18037 is more their ballpark as it fixes partial system culture matching in help (e.g. so that |
|
🎉 Handy links: |
PR Summary
Add
-AsOSC52switch toSet-ClipboardPR Context
Closes #18116
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).