X Tutup
Skip to content

Add helper in EnumSingleTypeConverter to get enum names as array #17785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Jan 2, 2025
Merged

Add helper in EnumSingleTypeConverter to get enum names as array #17785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9f6a37
add helper to get enum names
fflaten Jul 27, 2022
fcc4be6
update switch statement completer to use helper
fflaten Jul 27, 2022
1662033
Merge branch 'master' into cleanup-getenumnames
iSazonov Jan 2, 2025
1fdc88a
Restore GetEnumNames()
iSazonov Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7705,9 +7705,7 @@ internal static List<CompletionResult> CompleteStatementFlags(TokenKind kind, st
bool withColon = wordToComplete.EndsWith(':');
wordToComplete = withColon ? wordToComplete.Remove(wordToComplete.Length - 1) : wordToComplete;

string enumString = LanguagePrimitives.EnumSingleTypeConverter.EnumValues(typeof(SwitchFlags));
string separator = CultureInfo.CurrentUICulture.TextInfo.ListSeparator;
string[] enumArray = enumString.Split(separator, StringSplitOptions.RemoveEmptyEntries);
string[] enumArray = LanguagePrimitives.EnumSingleTypeConverter.GetEnumNames(typeof(SwitchFlags));

var pattern = WildcardPattern.Get(wordToComplete + "*", WildcardOptions.IgnoreCase);
var enumList = new List<string>();
Expand Down
8 changes: 8 additions & 0 deletions src/System.Management.Automation/engine/LanguagePrimitives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,6 +2077,14 @@ internal static string EnumValues(Type enumType)
return string.Join(CultureInfo.CurrentUICulture.TextInfo.ListSeparator, enumHashEntry.names);
}

/// <summary>
/// Returns all names for the provided enum type.
/// </summary>
/// <param name="enumType">The enum type to retrieve names from.</param>
/// <returns>Array of enum names for the specified type.</returns>
internal static string[] GetEnumNames(Type enumType)
=> EnumSingleTypeConverter.GetEnumHashEntry(enumType).names;

/// <summary>
/// Returns all values for the provided enum type.
/// </summary>
Expand Down
X Tutup