Add helper in EnumSingleTypeConverter to get enum names as array#17785
Merged
iSazonov merged 4 commits intoPowerShell:masterfrom Jan 2, 2025
Merged
Add helper in EnumSingleTypeConverter to get enum names as array#17785iSazonov merged 4 commits intoPowerShell:masterfrom
iSazonov merged 4 commits intoPowerShell:masterfrom
Conversation
Contributor
Author
|
Feels like random failures. Rerun? |
Contributor
Author
|
Just noticed that #17684 plan to replace this code. This PR can be closed if the other one is accepted. |
iSazonov
reviewed
Jul 28, 2022
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
iSazonov
approved these changes
Jan 2, 2025
Contributor
|
📣 Hey @fflaten, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds a helper in
EnumSingleTypeConverterto get enum names-array.Updates switch statement completer to use the new helper instead of string joining + splitting.
PR Context
Related #17750 (comment)
There's another occurrence in
CompletionCompleters.cswhich is replaced as part of the PR above.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).