X Tutup
Skip to content

Add Linux package dependencies for packaging#16807

Merged
TravisEz13 merged 10 commits intoPowerShell:masterfrom
TravisEz13:fix-linux-build-failures
Jan 27, 2022
Merged

Add Linux package dependencies for packaging#16807
TravisEz13 merged 10 commits intoPowerShell:masterfrom
TravisEz13:fix-linux-build-failures

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Jan 26, 2022 •
edited
Loading

PR Summary

Add Linux package dependencies for packaging

PR Context

PR Checklist

@ghost ghost assigned PaulHigin Jan 26, 2022
PaulHigin
PaulHigin approved these changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TravisEz13
TravisEz13 commented Jan 26, 2022
View reviewed changes
adityapatwardhan
adityapatwardhan requested changes Jan 26, 2022
View reviewed changes
build.psm1 Outdated

[Parameter()]
[string[]]
$Logs
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is not used. $logs is overwritten in line 1927

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 26, 2022
TravisEz13
TravisEz13 commented Jan 27, 2022
View reviewed changes
@PaulHigin
Copy link
Copy Markdown
Contributor

PaulHigin commented Jan 27, 2022

@TravisEz13 Please look at failed builds ('A parameter cannot be found that matches parameter name 'Logs'.').

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Jan 27, 2022

This PR has 47 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +33 -14
Percentile : 18.8%

Total files changed: 2

Change summary by file extension:
.psm1 : +32 -13
.ps1 : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 enabled auto-merge (squash) January 27, 2022 18:36
@TravisEz13 TravisEz13 merged commit 0b80b50 into PowerShell:master Jan 27, 2022
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 24, 2022
@ghost
Copy link
Copy Markdown

ghost commented Feb 24, 2022

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@TravisEz13
Add Linux package dependencies for packaging (PowerShell#16807)
d2626e6
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 14, 2022
@TravisEz13
Add Linux package dependencies for packaging (PowerShell#16807)
4618a94
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 15, 2022
@TravisEz13
Add Linux package dependencies for packaging (PowerShell#16807)
abb88ca 
# Conflicts:
#	build.psm1
#	tools/releaseBuild/Images/microsoft_powershell_windowsservercore/PowerShellPackage.ps1
@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2022

🎉v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2022

🎉v7.2.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 deleted the fix-linux-build-failures branch March 31, 2022 18:14
@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PaulHigin PaulHigin

Labels

Backport-7.0.x-Done BackPort-7.1.x-Done Backport to 7.1.x completed Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TravisEz13 @PaulHigin @adityapatwardhan
X Tutup