Fix parsing SemanticVersion build label from version string#16608
Fix parsing SemanticVersion build label from version string#16608daxian-dbw merged 4 commits intoPowerShell:masterfrom
Conversation
82cb8e5 to
619e49c
Compare
39f5e91 to
2e1723a
Compare
2e1723a to
c23a775
Compare
5fa47be to
bffdbac
Compare
|
@iSazonov I believe this is ready for a review. I choose a good test case because my initial fix wasn't quite right according to the spec. Now I believe we are properly parsing the labels. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@JoeRobich Thanks for your contribution! |
|
🎉 Handy links: |
PR Summary
Improve the SemanticVersion parsing logic to handle missing cases.
PR Context
Parsing semantic version strings of the form
major.minor.patch+releaseis broken.Here is an example from PowerShell 7.2:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).