X Tutup
Skip to content

Update .NET to version 6.0.100-preview.2.21155.3#15007

Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:UpdateDotNet6p2
Mar 15, 2021
Merged

Update .NET to version 6.0.100-preview.2.21155.3#15007
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:UpdateDotNet6p2

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Mar 12, 2021 •
edited
Loading

PR Summary

Update the .NET SDK to .NET 6 preview 2.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Mar 12, 2021
anmenaga
anmenaga suggested changes Mar 12, 2021
View reviewed changes
src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated
Copy link
Copy Markdown

@anmenaga anmenaga Mar 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like it is related to bumping .NET version. Probably better to move this to a separate PR.

Copy link
Copy Markdown
Member Author

@adityapatwardhan adityapatwardhan Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to this issue i reported: dotnet/roslyn#51849

assets/wix/files.wxs Outdated
Copy link
Copy Markdown

@anmenaga anmenaga Mar 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why this System.Speech.dll is mentioned here (looks like it was added by this PR)?

Copy link
Copy Markdown
Member Author

@adityapatwardhan adityapatwardhan Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comes with the framework i guess

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Mar 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reported to .Net Runtime repo.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 12, 2021
anmenaga
anmenaga reviewed Mar 12, 2021
View reviewed changes
src/System.Management.Automation/System.Management.Automation.csproj Outdated
Copy link
Copy Markdown

@anmenaga anmenaga Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curios why System.Security.Cryptography.Pkcs was on version="5.0.1" while all neighbor items were on 6.0.0-preview.1 - is this expected or something we missed previously?

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov Mar 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not all packages was updated in .Net Runtime for Preview.1. There are another packages like this.

Copy link
Copy Markdown
Member Author

@adityapatwardhan adityapatwardhan Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we missed updating a couple of packages for preview 1. Should not be a problem this release though.

@anmenaga anmenaga added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 12, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 12, 2021
@rjmholt rjmholt assigned rjmholt and unassigned anmenaga Mar 15, 2021
@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Mar 15, 2021

Snapstore has an outage which is cause the link tests to fail.

@adityapatwardhan adityapatwardhan merged commit 5c4a80e into PowerShell:master Mar 15, 2021
@adityapatwardhan adityapatwardhan deleted the UpdateDotNet6p2 branch March 15, 2021 18:22
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.4 milestone Mar 15, 2021
@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2021

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@anmenaga anmenaga anmenaga requested changes

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.4

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @rjmholt @anmenaga @iSazonov
X Tutup