X Tutup
Skip to content

Use string.Contains(char) overload#14368

Merged
iSazonov merged 1 commit intoPowerShell:masterfrom
xtqqczze:contains-char
Dec 19, 2020
Merged

Use string.Contains(char) overload#14368
iSazonov merged 1 commit intoPowerShell:masterfrom
xtqqczze:contains-char

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Dec 9, 2020

Avoid some small string allocations.

The overload is available since .NET Core 2.1.

See also: dotnet/coreclr#15740

Avoid some small string allocations.

The overload is available since .NET Core 2.1.

See also: dotnet/coreclr#15740
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 12, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 19, 2020
@ghost
Copy link
Copy Markdown

ghost commented Dec 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 19, 2020
@iSazonov iSazonov merged commit 5f3dd93 into PowerShell:master Dec 19, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Dec 19, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

Submitted #14465 for String.Split(char) overload.

@xtqqczze xtqqczze deleted the contains-char branch December 19, 2020 16:05
@ghost
Copy link
Copy Markdown

ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup