X Tutup
Skip to content

Enable nullable: System.Management.Automation.Provider.IContentCmdletProvider#14184

Merged
iSazonov merged 2 commits intoPowerShell:masterfrom
powercode:nullable/IContentCmdletProvider
Dec 11, 2020
Merged

Enable nullable: System.Management.Automation.Provider.IContentCmdletProvider#14184
iSazonov merged 2 commits intoPowerShell:masterfrom
powercode:nullable/IContentCmdletProvider

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

Tracking issue: #12631.

@powercode powercode requested a review from anmenaga as a code owner November 20, 2020 00:09
@ghost ghost assigned iSazonov Nov 20, 2020
Comment on lines +4 to 6
#nullable enable

namespace System.Management.Automation.Provider
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok to have the directive here since it is for whole file.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@iSazonov iSazonov requested a review from vexx32 November 20, 2020 06:56
Copy link
Copy Markdown
Collaborator

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🙂

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link
Copy Markdown

ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Copy Markdown
Collaborator

@rjmholt Please review.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 11, 2020
@iSazonov iSazonov merged commit d487537 into PowerShell:master Dec 11, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@powercode powercode deleted the nullable/IContentCmdletProvider branch December 14, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup