Enable nullable: System.Management.Automation.Host.IHostUISupportsMultipleChoiceSelection#14172
Merged
iSazonov merged 3 commits intoPowerShell:masterfrom Jan 9, 2021
Conversation
…tipleChoiceSelection
iSazonov
requested changes
Nov 20, 2020
Comment on lines
1233
to
+1235
|
|
||
| #nullable restore | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| #nullable restore | |
| #nullable restore | |
Comment on lines
+1199
to
+1200
| #nullable enable | ||
|
|
Collaborator
There was a problem hiding this comment.
Please move to line 1206.
| /// <seealso cref="System.Management.Automation.Host.PSHostUserInterface.PromptForChoice"/> | ||
| Collection<int> PromptForChoice(string caption, string message, | ||
| Collection<ChoiceDescription> choices, IEnumerable<int> defaultChoices); | ||
| Collection<int> PromptForChoice(string? caption, string? message, |
Collaborator
There was a problem hiding this comment.
Please add in XML comment - implementations should never return null.
Collaborator
Author
There was a problem hiding this comment.
This will be a compiler warning - I don't see the point of stating the obvious.
ghost
added
the
Waiting on Author
ghost
removed
the
Waiting on Author
iSazonov
approved these changes
Nov 21, 2020
iSazonov
added
the
CL-CodeCleanup
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #12631.