Restrict New-Object in NoLanguage mode under lock down #14139#14140
Merged
rjmholt merged 15 commits intoPowerShell:masterfrom Dec 8, 2020
Merged
Restrict New-Object in NoLanguage mode under lock down #14139#14140rjmholt merged 15 commits intoPowerShell:masterfrom
rjmholt merged 15 commits intoPowerShell:masterfrom
Conversation
ghost
assigned
added 2 commits
November 18, 2020 21:29
SteveL-MSFT
changed the title
iSazonov
added
the
CL-General
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Contributor
Author
|
The test case passed on my local machine where as it failed in the CI. |
added 2 commits
December 1, 2020 18:59
rjmholt
reviewed
Dec 3, 2020
src/Microsoft.PowerShell.Commands.Utility/resources/NewObjectStrings.resx
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/New-Object.cs
Outdated
Show resolved
Hide resolved
Collaborator
The screenshot you've showed there isn't CI failing or passing. Those tests are being skipped. I'm guessing it's a non-Windows CI machine? |
added 5 commits
December 3, 2020 11:42
This reverts commit 27134a0.
rjmholt
reviewed
Dec 3, 2020
src/Microsoft.PowerShell.Commands.Utility/commands/utility/New-Object.cs
Outdated
Show resolved
Hide resolved
rjmholt
approved these changes
Dec 4, 2020
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Restrict New-Object in NoLanguage mode under lock down #14139
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.