Update README and metadata.json for 7.2.0-preview.1 release#14104
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Nov 18, 2020
Merged
Update README and metadata.json for 7.2.0-preview.1 release#14104adityapatwardhan merged 3 commits intoPowerShell:masterfrom
README and metadata.json for 7.2.0-preview.1 release#14104adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
daxian-dbw
requested review from
TravisEz13,
adityapatwardhan and
anmenaga
as code owners
ghost
assigned
adityapatwardhan
approved these changes
Nov 16, 2020
iSazonov
reviewed
Nov 18, 2020
Comment on lines
+100
to
+102
| [pv-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.9_amd64.deb | ||
| [pv-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.10_amd64.deb | ||
| [pv-debian11]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.11_amd64.deb |
Collaborator
There was a problem hiding this comment.
For Ubuntu we sort versions from high to low :-)
Member
Author
There was a problem hiding this comment.
The order doesn't matter. Those link references are not visible to users.
iSazonov
reviewed
Nov 18, 2020
Comment on lines
+107
to
+108
| [pv-winx86-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x86.zip | ||
| [pv-winx64-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x64.zip |
Collaborator
There was a problem hiding this comment.
Maybe put x64 on top as above for msi? (Swap line 107 and 108)
Member
Author
There was a problem hiding this comment.
The order doesn't matter. Those link references are not visible to users.
iSazonov
reviewed
Nov 18, 2020
Comment on lines
+111
to
+112
| [pv-arm32]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm32.tar.gz | ||
| [pv-arm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm64.tar.gz |
daxian-dbw
added
the
CL-BuildPackaging
Member
Author
|
@adityapatwardhan I made a couple fixes. Can you please review again? Thanks! |
adityapatwardhan
approved these changes
Nov 18, 2020
|
Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update
READMEandmetadata.jsonfor 7.2.0-preview.1 release.Changes to be noted:
pv-ubuntu20pv-winarmPR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.