X Tutup
Skip to content

Use Microsoft.PowerShell.MarkdownRender package from nuget.org#14090

Merged
rjmholt merged 3 commits intoPowerShell:masterfrom
adityapatwardhan:RemoveMarkRender
Dec 9, 2020
Merged

Use Microsoft.PowerShell.MarkdownRender package from nuget.org#14090
rjmholt merged 3 commits intoPowerShell:masterfrom
adityapatwardhan:RemoveMarkRender

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Nov 13, 2020

PR Summary

The code for Microsoft.PowerShell.MarkdownRender has been moved to a separate repository https://github.com/powershell/markdownrender. This PR removes the code from this repository and uses the package from nuget.org instead

PR Context

PR Checklist

@ghost ghost assigned rjmholt Nov 13, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Nov 14, 2020 •
edited
Loading

I see the initial commit PowerShell/MarkdownRender@345e2f3 was on 2020-10-02. We should ensure changes made in the last few months are reflected in powershell/markdownrender:

TravisEz13
TravisEz13 requested changes Nov 19, 2020
View reviewed changes
tools/packaging/packaging.psm1 Outdated
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be signed in your build, so can you remove it from our signing?

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 19, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Nov 20, 2020

@TravisEz13 - please re-review

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Nov 20, 2020

@rjmholt This is ready for review now.

@adityapatwardhan adityapatwardhan mentioned this pull request Nov 20, 2020
Closed
@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Nov 20, 2020

@xtqqczze - Filed issue in MarkdownRender repo to make sure the improvements mentioned above are taken there: PowerShell/MarkdownRender#11

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Nov 24, 2020

@rjmholt This is ready to merge.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 2, 2020
@ghost
Copy link
Copy Markdown

ghost commented Dec 2, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Dec 2, 2020

@iSazonov We should avoid merging any more changes to Microsoft.PowerShell.MarkdownRender, like those in #14078.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Dec 2, 2020

@iSazonov We should avoid merging any more changes to Microsoft.PowerShell.MarkdownRender, like those in #14078.

These files will simply be deleted - this does not affect anything.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 2, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 9, 2020
@ghost
Copy link
Copy Markdown

ghost commented Dec 9, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt
Copy link
Copy Markdown
Collaborator

rjmholt commented Dec 9, 2020

@PoshChan please remind me in 1 hour

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 9, 2020
@rjmholt rjmholt added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 9, 2020
@rjmholt rjmholt merged commit 600b658 into PowerShell:master Dec 9, 2020
@rjmholt rjmholt deleted the RemoveMarkRender branch December 9, 2020 20:29
@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Dec 9, 2020

@rjmholt, this is the reminder you requested 1 hour ago

@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 10, 2020
@rjmholt rjmholt mentioned this pull request Dec 10, 2020
Merged
14 tasks
@ghost
Copy link
Copy Markdown

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze mentioned this pull request Jun 29, 2021
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@rjmholt rjmholt

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

6 participants

@adityapatwardhan @xtqqczze @iSazonov @rjmholt @PoshChan @TravisEz13
X Tutup