Fix typo in MapSecurityZone#13921
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Nov 3, 2020
Merged
Conversation
SteveL-MSFT
approved these changes
Oct 29, 2020
Collaborator
Author
|
I could add xUnit tests for the code (in follow PR). |
PaulHigin
approved these changes
Oct 29, 2020
Contributor
|
I think test are definitely called for, given the potentially grave consequences of such a logic error. |
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Nov 10, 2020
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix typo which comes from #11884 - "Internet" and "Intranet" names are too similar.
Discovered by @mklement0 #13869 (comment)
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.