Provide parser with path to script file executed by means of -File command line argument by m5x · Pull Request #12494 · PowerShell/PowerShell

m5x · 2020-04-25T23:16:28Z

PR Summary

Allow System.Management.Automation.Runspaces.Command operating in IsScript = true mode to remember and pass on path to the script file and make use of this feature when executing script file passed as -File command line argument.

PR Context

Fixes #4217

…mmand line argument

msftclas · 2020-04-25T23:16:41Z

All CLA requirements met.

vexx32

Code seems sound, nice work!

Can we add a test to verify this works and guard against regressions?

iSazonov

Please add tests.

src/System.Management.Automation/engine/hostifaces/Command.cs

…tion.InvocationName contain proper values when running script by means of -File argument

m5x · 2020-04-27T03:19:41Z

Tests have been added. I also added one small change to use ExternalScriptInfo for scripts with known path (i.e. scripts started with -File argument) and thus provide proper values in $MyInvocation special variable even for scripts without .ps1 extension.

m5x · 2020-04-27T03:38:40Z

Sorry for the spacing around parentheses. I like to put spaces inside for better readability and I've been doing it so long that I type it automatically this way and sometimes forget to check and fix it when committing to other projects. I will fix it in next commit - should I add [Feature] prefix to the commit message again to comply with testing guidelines in case it is the last one of this PR?

src/System.Management.Automation/engine/hostifaces/Command.cs

….Runspaces.Command class

m5x · 2020-04-27T19:05:14Z

Added the requested formatting and property docs changes. CodeFactor reports no more issues.

src/System.Management.Automation/engine/hostifaces/Command.cs

ghost · 2020-05-27T02:00:59Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-07-23T07:59:21Z

@m5x Please rebase to pass CIs.

ghost · 2020-07-30T14:00:22Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

m5x · 2020-07-30T16:46:02Z

Is rebasing all that's blocking merge of this pull request? I have currently some other things I have to finish first but if I am the only one blocking this I'll try to find a time to rebase this weekend.

iSazonov · 2020-08-01T18:03:23Z

It is a question for MSFT team - @daxian-dbw @anmenaga have you time to review the PR?

daxian-dbw · 2020-08-03T17:08:32Z

Add @SteveL-MSFT and @rjmholt to review.
@SteveL-MSFT You marked the issue "by design" in #4217 (comment), can you please review this PR and the subsequent comments in that issue to see if we want to accept this PR? Also would the change of design cause any breaking change?

src/System.Management.Automation/engine/hostifaces/Command.cs

ghost · 2020-08-11T02:00:21Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

ghost · 2020-12-09T23:49:44Z

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

src/System.Management.Automation/engine/hostifaces/Command.cs

rjmholt · 2020-12-10T20:48:03Z

Blocked on #12494 (comment); @SteveL-MSFT or the @PowerShell/powershell-committee need to advise on whether we want to make this change

iSazonov · 2020-12-11T03:59:08Z

src/System.Management.Automation/engine/hostifaces/Command.cs

                    commandProcessorBase = new CommandProcessor(functionInfo, executionContext,
                                                                _useLocalScope ?? false, fromScriptFile: false, sessionState: executionContext.EngineSessionState);
                }
+                else if (ScriptPath != null)


Suggested change

else if (ScriptPath != null)

else if (ScriptPath is not null)

ghost · 2020-12-18T14:00:09Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

ghost · 2021-09-23T02:01:02Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

jazzdelightsme

daxian-dbw · 2022-01-18T23:52:29Z

test/powershell/Host/ConsoleHost.Tests.ps1

+            param($Filename)
+            $testFilePath = Join-Path $testdrive $Filename
+            Set-Content -Path $testFilePath -Value '$MyInvocation.MyCommand.Name'
+            $observed = & $powershell -File $testFilePath -NoProfile -NoLogo


There was an intentional breaking change in PowerShell 7.2 related to powershell -File: when running on Windows, a file without .ps1 extension is not allowed to run using pwsh -File. So, the test won't work on Windows.

daxian-dbw · 2022-01-18T23:55:44Z

src/System.Management.Automation/engine/hostifaces/Command.cs

                }
+                else if (ScriptPath != null)
+                {
+                    var scriptName = Path.GetFileName(ScriptPath);


The script (content of the file) could be using cmdlet binding (scriptBlock.UsesCmdletBinding being true), by having a param block defined. In that case, the code execution would fall into the if (scriptBlock.UsesCmdletBinding) block, right?

ghost · 2022-02-03T02:00:40Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

Provide parser with path to script file executed by means of -File co…

637b91e

…mmand line argument

m5x requested review from anmenaga and daxian-dbw as code owners April 25, 2020 23:16

ghost assigned iSazonov Apr 25, 2020

vexx32 reviewed Apr 26, 2020

View reviewed changes

iSazonov reviewed Apr 26, 2020

View reviewed changes

src/System.Management.Automation/engine/hostifaces/Command.cs Outdated Show resolved Hide resolved

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 26, 2020

iSazonov added this to the 7.1.0-preview.3 milestone Apr 26, 2020

m5x added 2 commits April 27, 2020 02:59

Use ExternalScriptInfo when executing script with known path

9c8e803

[Feature] Test PSScriptRoot, MyInvocation.MyCommand.Name and MyInvoca…

dc6d27b

…tion.InvocationName contain proper values when running script by means of -File argument

iSazonov reviewed Apr 27, 2020

View reviewed changes

src/System.Management.Automation/engine/hostifaces/Command.cs Outdated Show resolved Hide resolved

Fix some formatting and property docs in System.Management.Automation…

6bad424

….Runspaces.Command class

iSazonov reviewed Apr 28, 2020

View reviewed changes

src/System.Management.Automation/engine/hostifaces/Command.cs Show resolved Hide resolved

TravisEz13 modified the milestones: 7.1.0-preview.3, 7.1.0-preview.4 May 14, 2020

ghost added the Review - Needed The PR is being reviewed label May 27, 2020

adityapatwardhan removed this from the 7.1.0-preview.4 milestone Jun 29, 2020

m5x mentioned this pull request Jul 22, 2020

Unix: A script without .ps1 extension passed to the powershell binary lacks invocation information ($PSCommandPath, $MyInvocation), such as when invoked via a shebang line. #4217

Closed

ghost removed the Review - Needed The PR is being reviewed label Jul 23, 2020

ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020

ghost removed the Review - Needed The PR is being reviewed label Aug 1, 2020

daxian-dbw requested review from SteveL-MSFT and rjmholt August 3, 2020 17:05

rjmholt approved these changes Aug 3, 2020

View reviewed changes

src/System.Management.Automation/engine/hostifaces/Command.cs Outdated Show resolved Hide resolved

ghost added the Review - Needed The PR is being reviewed label Aug 11, 2020

SteveL-MSFT added this to the 7.2-Consider milestone Dec 9, 2020

ghost removed this from the 7.2-Consider milestone Dec 9, 2020

SteveL-MSFT added the Backport-7.2.0-Consider label Dec 10, 2020

rjmholt reviewed Dec 10, 2020

View reviewed changes

src/System.Management.Automation/engine/hostifaces/Command.cs Outdated Show resolved Hide resolved

Update src/System.Management.Automation/engine/hostifaces/Command.cs

0806edd

ghost removed the Review - Needed The PR is being reviewed label Dec 10, 2020

iSazonov reviewed Dec 11, 2020

View reviewed changes

ghost added the Review - Needed The PR is being reviewed label Dec 18, 2020

adityapatwardhan removed the Backport-7.2.x-Consider label Sep 15, 2021

ghost removed the Review - Needed The PR is being reviewed label Sep 15, 2021

ghost added the Review - Needed The PR is being reviewed label Sep 23, 2021

jazzdelightsme approved these changes Jan 14, 2022

View reviewed changes

daxian-dbw requested changes Jan 18, 2022

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Jan 18, 2022

ghost added the Stale label Feb 3, 2022

ghost closed this Feb 13, 2022

This pull request was closed.

	else if (ScriptPath != null)
	else if (ScriptPath is not null)

Conversation

m5x commented Apr 25, 2020

PR Summary

PR Context

Uh oh!

msftclas commented Apr 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vexx32 left a comment

Choose a reason for hiding this comment

Uh oh!

iSazonov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

m5x commented Apr 27, 2020

Uh oh!

m5x commented Apr 27, 2020

Uh oh!

Uh oh!

m5x commented Apr 27, 2020

Uh oh!

Uh oh!

ghost commented May 27, 2020

Uh oh!

iSazonov commented Jul 23, 2020

Uh oh!

ghost commented Jul 30, 2020

Uh oh!

m5x commented Jul 30, 2020

Uh oh!

iSazonov commented Aug 1, 2020

Uh oh!

daxian-dbw commented Aug 3, 2020

Uh oh!

Uh oh!

ghost commented Aug 11, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

Uh oh!

rjmholt commented Dec 10, 2020

Uh oh!

iSazonov Dec 11, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 18, 2020

Uh oh!

ghost commented Sep 23, 2021

Uh oh!

jazzdelightsme left a comment

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jan 18, 2022

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jan 18, 2022

Choose a reason for hiding this comment

Uh oh!

ghost commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

msftclas commented Apr 25, 2020 •

edited

Loading