Polish context menu - pixelorama.nsi#972
Polish context menu - pixelorama.nsi#972piotrtrkostrzewski94 wants to merge 1 commit intoOrama-Interactive:masterfrom
Conversation
I added a translation to the Edit project with Pixelorama context menu into Polish.
|
Translations are done through crowdin on https://crowdin.com/project/pixelorama. You can submit translations there and they get imported into the project every few weeks. It's easier for translators to work on it this way. |
|
I know this, I'm a Pixelorama translator there. There is no context menu added on CrowdIn. It's not a problem for me to add a commit here. I hope the creators don't mind this. |
|
Well in that case, that entry needs to be added to crowdin instead :) |
|
Never mind this is for installer and not the main application. I have no clue how those are handled 😅 |
|
Maybe they will add it for other languages, there is no need for Polish :) In my opinion, it is for the main application because it is in the context menu :) |
| ; Multilingual support | ||
|
|
||
| !insertmacro MUI_LANGUAGE "English" | ||
| !insertmacro MUI_LANGUAGE "Polski" |
There was a problem hiding this comment.
This change looks incorrect to me, it seems to be replacing English with Polish rather than adding it as a new translation. I'm not entirely familiar with how .nsi files work so I'm not sure what the correct solution is here.
| WriteRegStr HKCR "Pixelorama project\DefaultIcon" "" "$INSTDIR\pxo.ico" | ||
|
|
||
| WriteRegStr HKCR "Pixelorama project\shell\open\command" "" '$INSTDIR\${APPNAME}.exe "%1"' | ||
| WriteRegStr HKCR "Pixelorama project\shell\edit" "" "Edit project in ${APPNAME}" |
There was a problem hiding this comment.
In the file I sent, there is a Polish version of the context menu on line 155. Should I add a new file
called pixelorama-pl.nsl?
There was a problem hiding this comment.
I made a mistake, I could have added it immediately as a new file and added PR. Sorry, I'm still learning Github. I sent the correct (I hope) PR.
3 participants
I added a translation to the "Edit project with Pixelorama" context menu into Polish.