Fix "Add extensions" button not working in Android

OverloadedOrama · OverloadedOrama · commit f3ca301296a0 · 2026-02-23T17:56:36.000+02:00
diff --git a/src/HandleExtensions.gd b/src/HandleExtensions.gd
@@ -96,10 +96,11 @@ func _add_internal_extensions() -> void:
 
 
 func install_extension(path: String) -> void:
-	var file_name := path.get_file()
+	var file_name := path.uri_decode().get_file()
 	var err := DirAccess.copy_absolute(path, EXTENSIONS_PATH.path_join(file_name))
 	if err != OK:
-		print(err)
+		var msg := tr("Extension failed to install. Error code %s (%s)") % [err, error_string(err)]
+		Global.popup_error(msg)
 		return
 	_add_extension(file_name)
 
@@ -125,13 +126,16 @@ func _add_extension(file_name: String) -> void:
 
 
 func _load_extension(extension_file_or_folder_name: StringName, internal := false) -> void:
-	var file_name_no_ext := extension_file_or_folder_name.get_basename()
+	var file_name_no_ext := extension_file_or_folder_name.uri_decode().get_basename()
 	var extension_path := "res://src/Extensions/%s/" % file_name_no_ext
 	var extension_config_file_path := extension_path.path_join("extension.json")
 	var extension_config_file := FileAccess.open(extension_config_file_path, FileAccess.READ)
 	var err := FileAccess.get_open_error()
 	if err != OK:
-		print("Error loading config file: ", err, " (", error_string(err), ")")
+		var msg := (
+			tr("Error loading extension config file. Error code %s (%s)") % [err, error_string(err)]
+		)
+		Global.popup_error(msg)
 		if extension_config_file:
 			extension_config_file.close()
 		return
@@ -142,7 +146,7 @@ func _load_extension(extension_file_or_folder_name: StringName, internal := fals
 	extension_config_file.close()
 
 	if not extension_json:
-		print("No JSON data found.")
+		Global.popup_error(tr("No JSON data found in the extension."))
 		return
 
 	if extension_json.has("supported_api_versions"):
diff --git a/src/Preferences/ExtensionsPreferences.gd b/src/Preferences/ExtensionsPreferences.gd
@@ -21,7 +21,6 @@ func _ready() -> void:
 	delete_confirmation.add_button("Move to Trash", false, Extensions.BIN_ACTION)
 	if OS.get_name() == "Web":
 		$HBoxContainer/AddExtensionButton.disabled = true
-		$HBoxContainer/OpenFolderButton.visible = false
 	else:
 		# TODO: Remove the loop when https://github.com/godotengine/godot/issues/92848 gets fixed.
 		for dialog_child in add_extension_file_dialog.find_children("", "Window", true, false):
diff --git a/src/Preferences/PreferencesDialog.tscn b/src/Preferences/PreferencesDialog.tscn
@@ -1441,7 +1441,7 @@ mouse_default_cursor_shape = 2
 disabled = true
 text = "Uninstall"
 
-[node name="OpenFolderButton" type="Button" parent="HSplitContainer/VBoxContainer/ScrollContainer/RightSide/Extensions/HBoxContainer" unique_id=1324879976]
+[node name="OpenFolderButton" type="Button" parent="HSplitContainer/VBoxContainer/ScrollContainer/RightSide/Extensions/HBoxContainer" unique_id=1324879976 groups=["DesktopOnly"]]
 layout_mode = 2
 mouse_default_cursor_shape = 2
 text = "Open Folder"
