Alloc: Remove in tree heaplogging and avoid adding align to mallocs#1318
Open
mkuoppal wants to merge 2 commits intoNetHack:NetHack-3.7from
Open
Alloc: Remove in tree heaplogging and avoid adding align to mallocs#1318mkuoppal wants to merge 2 commits intoNetHack:NetHack-3.7from
mkuoppal wants to merge 2 commits intoNetHack:NetHack-3.7from
Conversation
Contributor
mkuoppal
commented
Nov 8, 2024
- Remove MONITOR_HEAP as there is adequate external tooling to cover similar functionality.
- Avoid aligning mallocs to give full control to memory access debug tooling
MONITOR_HEAP is a define which is used to track memory allocations by file and line number. Altho this has been useful to memory allocation problems, the modern development environment have plethora of tools just for this purpose: valgrind, mtrace, electric fence, asan, msan etc. Thus there should be no need to carry in tree malloc debugging. Remove MONITOR_HEAP functionality.
Do not kneel in front of bad static analyzers and try to align your allocs. This method of extending/aligning over the native malloc uapi will render some of the memory/malloc analyzer detection useless, like not seeing out of bounds accesses on non aligned ones. Instead of catering to some bad analyzer, use native malloc and thus give full visibility to proper ones. If some architecture still needs aligment to long, it should be special cased and not taint the sane ones. Remove aligment padding from alloc(), return void ptrs like in native malloc and deny zero sized allocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.