Conversation
In case animation name starts with "-", parseSingle method breaks. this is just a simple workaround
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Fixed it by catching the error & ignoring it instead. This workaround only prevented the error, but would introduce another issue... the animation would be renamed & never found if you removed the leading The animation: -hightlight-light .3s ease-out forwards;Which is then treated as a number here: https://github.com/hookhookun/parse-animation-shorthand/blob/2a54be6c659115bced4f198d90fe7e3be884711b/src/parseSingleAnimationShorthand.ts#L52-L64 and throwing at the else condition. |
In case animation name starts with "-", parseSingle method breaks. this is just a simple workaround