Merged
Conversation
It worked fine locally on msys2 but for some reason github actions need HarfBuzz_VERSION defined.
Member
|
|
Member
|
Android and macOS changes missing? |
Also shape with full context so there is no need for cluster offset
Also expose isRTL for possible future use.
Use "|" for cursor that makes it much more clear where the current position is, especially in rtl text, and allows to draw it after end of rtl text (leftmost).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated bidi reordering. Now sheenbidi just splits text into runs and harfbuzz does ltr/rtl conversion.
Now CGUITTFont handles cursor position, mark ranges etc. so less code duplication and looks simpler. Sheenbidi has been moved to MultiCraft.
I think that better font is needed for arabic text. I was testing with DejaVuSans.ttf.
I'm pretty sure you will still find some minor issues but it mostly works fine.
One thing that could still be optimized is that shapeText() can be called multiple times for the same text. For example when get dimension, get mark rects and later draw text. It could just shape it once.
Needs MoNTE48/Irrlicht#36