background: fix loading background along with scene#154
Open
yookoala wants to merge 3 commits intoMonogatari:developfrom
Open
background: fix loading background along with scene#154yookoala wants to merge 3 commits intoMonogatari:developfrom
yookoala wants to merge 3 commits intoMonogatari:developfrom
Conversation
* Background should be of higher priority than scene. So the presents of Scene should not prevent Background from taking effect.
Contributor
Author
|
I'm not 100% sure about this. The original |
* Fix the warning for "context", "cy" and etc. marked as undefined by eslint.
* Correctly display background image if not loaded by show scene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR is needed?
To reproduce my issue
Expected behaviour
See the word "Hello" with the background "phone.jpg".
Actual behaviour
See the word "Hello" with the background color #555555. No phone.jpg.
What this PR does?
of Scene should not prevent Background from taking effect.