TestType() : TestFixture("TestType") {

}

void run() {

TEST_CASE(checkTooBigShift_Unix32);

TEST_CASE(checkIntegerOverflow);

TEST_CASE(signConversion);

TEST_CASE(longCastAssign);

TEST_CASE(longCastReturn);

TEST_CASE(checkFloatToIntegerOverflow);

}

void check(const char code[], Settings* settings = 0, const char filename[] = "test.cpp") {

// Clear the error buffer..

errout.str("");

if (!settings) {

static Settings _settings;

settings = &_settings;

}

settings->addEnabled("warning");

// Tokenize..

Tokenizer tokenizer(settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, filename);

// Check..

CheckType checkType(&tokenizer, settings, this);

checkType.runChecks(&tokenizer, settings, this);

}

void checkTooBigShift_Unix32() {

Settings settings;

settings.platform(Settings::Unix32);

check("int foo(unsigned int x) {\n"

" return x << 32;\n"

"}",&settings);

ASSERT_EQUALS("[test.cpp:2]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n", errout.str());

check("x = (short)x << 31;",&settings);

ASSERT_EQUALS("[test.cpp:1]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour\n", errout.str());

check("int foo(int x) {\n"

" return x << 2;\n"

"}",&settings);

ASSERT_EQUALS("", errout.str());

check("int foo(int x) {\n"

" return (long long)x << 40;\n"

"}",&settings);

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" QList<int> someList;\n"

" someList << 300;\n"

"}", &settings);

ASSERT_EQUALS("", errout.str());

// Ticket #6793

check("template<unsigned int I> int foo(unsigned int x) { return x << I; }\n"

"const unsigned int f = foo<31>(0);\n"

"const unsigned int g = foo<100>(0);\n"

"template<unsigned int I> int hoo(unsigned int x) { return x << 32; }\n"

"const unsigned int h = hoo<100>(0);", &settings);

ASSERT_EQUALS("[test.cpp:4]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n"

"[test.cpp:1]: (error) Shifting 32-bit value by 100 bits is undefined behaviour\n", errout.str());

// #7266: C++, shift in macro

check("void f(unsigned int x) {\n"

" UINFO(x << 1234);\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void checkIntegerOverflow() {

Settings settings;

settings.platform(Settings::Unix32);

settings.addEnabled("warning");

check("x = (int)0x10000 * (int)0x10000;", &settings);

ASSERT_EQUALS("[test.cpp:1]: (error) Signed integer overflow for expression '(int)65536*(int)65536'.\n", errout.str());

check("x = (long)0x10000 * (long)0x10000;", &settings);

ASSERT_EQUALS("[test.cpp:1]: (error) Signed integer overflow for expression '(long)65536*(long)65536'.\n", errout.str());

check("void foo() {\n"

" int intmax = 0x7fffffff;\n"

" return intmax + 1;\n"

"}",&settings);

ASSERT_EQUALS("[test.cpp:3]: (error) Signed integer overflow for expression 'intmax+1'.\n", errout.str());

check("void foo() {\n"

" int intmax = 0x7fffffff;\n"

" return intmax - 1;\n"

"}",&settings);

ASSERT_EQUALS("", errout.str());

check("int foo(signed int x) {\n"

" if (x==123456) {}\n"

" return x * x;\n"

"}",&settings);

ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (warning) Either the condition 'x==123456' is redundant or there is signed integer overflow for expression 'x*x'.\n", errout.str());

check("int foo(signed int x) {\n"

" if (x==123456) {}\n"

" return -123456 * x;\n"

"}",&settings);

ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (warning) Either the condition 'x==123456' is redundant or there is signed integer overflow for expression '-123456*x'.\n", errout.str());

check("int foo(signed int x) {\n"

" if (x==123456) {}\n"

" return 123456U * x;\n"

"}",&settings);

ASSERT_EQUALS("", errout.str());

}

void signConversion() {

check("x = -4 * (unsigned)y;");

ASSERT_EQUALS("[test.cpp:1]: (warning) Suspicious code: sign conversion of -4 in calculation because '-4' has a negative value\n", errout.str());

check("unsigned int f1(signed int x, unsigned int y) {" // x is signed

" return x * y;\n"

"}\n"

"void f2() { f1(-4,4); }");

ASSERT_EQUALS("[test.cpp:1]: (warning) Suspicious code: sign conversion of x in calculation, even though x can have a negative value\n", errout.str());

check("unsigned int f1(int x) {" // x has no signedness, but it can have the value -1 so assume it's signed

" return x * 5U;\n"

"}\n"

"void f2() { f1(-4); }");

ASSERT_EQUALS("[test.cpp:1]: (warning) Suspicious code: sign conversion of x in calculation, even though x can have a negative value\n", errout.str());

check("unsigned int f1(int x) {" // #6168: FP for inner calculation

" return 5U * (1234 - x);\n" // <- signed subtraction, x is not sign converted

"}\n"

"void f2() { f1(-4); }");

ASSERT_EQUALS("", errout.str());

// Don't warn for + and -

check("void f1(int x) {"

" a = x + 5U;\n"

"}\n"

"void f2() { f1(-4); }");

ASSERT_EQUALS("", errout.str());

check("size_t foo(size_t x) {\n"

" return -2 * x;\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (warning) Suspicious code: sign conversion of -2 in calculation because '-2' has a negative value\n", errout.str());

}

void longCastAssign() {

Settings settings;

settings.addEnabled("style");

settings.platform(Settings::Unix64);

check("long f(int x, int y) {\n"

" const long ret = x * y;\n"

" return ret;\n"

"}\n", &settings);

ASSERT_EQUALS("[test.cpp:2]: (style) int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information.\n", errout.str());

// typedef

check("long f(int x, int y) {\n"

" const size_t ret = x * y;\n"

" return ret;\n"

"}\n", &settings);

ASSERT_EQUALS("", errout.str());

// astIsIntResult

check("long f(int x, int y) {\n"

" const long ret = (long)x * y;\n"

" return ret;\n"

"}\n", &settings);

ASSERT_EQUALS("", errout.str());

}

void longCastReturn() {

Settings settings;

settings.addEnabled("style");

check("long f(int x, int y) {\n"

" return x * y;\n"

"}\n", &settings);

ASSERT_EQUALS("[test.cpp:2]: (style) int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of information.\n", errout.str());

// typedef

check("size_t f(int x, int y) {\n"

" return x * y;\n"

"}\n", &settings);

ASSERT_EQUALS("", errout.str());

}

// This function ensure that test works with different compilers. Floats can

// be stringified differently.

static std::string removeFloat(const std::string& msg) {

std::string::size_type pos1 = msg.find("float (");

std::string::size_type pos2 = msg.find(") to integer conversion");

if (pos1 == std::string::npos || pos2 == std::string::npos || pos1 > pos2)

return msg;

return msg.substr(0,pos1+7) + msg.substr(pos2);

}

void checkFloatToIntegerOverflow() {

check("x = (int)1E100;");

ASSERT_EQUALS("[test.cpp:1]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout.str()));

check("void f(void) {\n"

" return (int)1E100;\n"

"}\n");

ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout.str()));

check("void f(void) {\n"

" return (int)-1E100;\n"

"}\n");

ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout.str()));

check("void f(void) {\n"

" return (short)1E6;\n"

"}\n");

ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout.str()));

check("void f(void) {\n"

" return (unsigned char)256.0;\n"

"}\n");

ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout.str()));

check("void f(void) {\n"

" return (unsigned char)255.5;\n"

"}\n");

ASSERT_EQUALS("", removeFloat(errout.str()));

check("void f(void) {\n"

" char c = 1234.5;\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout.str()));

}