Added "always show battery" toggle to clock widget#1799
Open
DemonicSavage wants to merge 8 commits intoMM2-0:mainfrom
Open
Added "always show battery" toggle to clock widget#1799DemonicSavage wants to merge 8 commits intoMM2-0:mainfrom
DemonicSavage wants to merge 8 commits intoMM2-0:mainfrom
Conversation
Removed unnecessary newline at the end of the file.
Author
|
What is going on? The original files had no newline at the end, my files also don't. It shouldn't be triggering a diff there |
Author
|
Btw, this should probably be seen as a fairly rough draft. Especially the settings toggle, it's pretty ugly. Also, I'm not so sure about the ideal ranking. 10 seems fine for now though. |
Owner
|
Maybe Battery should be a list preference with 3 options: "Never", "When low or charging" and "always" |
Author
|
Makes sense, done. |
Author
|
As this changes the current schema, I added the migration code. Unless I'm missing something, this should probably be all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably not the best way to do it, but this is good for people like me who like hiding the status bar.
Not my proudest code, I'm not a Kotlin dev at all. If there are better ways of doing what I'm doing please let me know.