Point ember-usable at the new github URL#346
Open
fusion2004 wants to merge 3 commits intoLevelbossMike:masterfrom
Open
Point ember-usable at the new github URL#346fusion2004 wants to merge 3 commits intoLevelbossMike:masterfrom
fusion2004 wants to merge 3 commits intoLevelbossMike:masterfrom
Conversation
Owner
|
@fusion2004 Thanks! This is breaking CI. Any ideas if this is related to your change? |
Author
|
I don't believe so, this shouldn't have any functional change. |
Owner
|
@fusion2004 Sorry for taking so long to merge this - Restarted the build. If it fails again I'll look into tweaking CI setup and switching over to Github actions. That's on our roadmap anyway and I feel it could make the build much more stable. Travis is just a pain these days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know #317 is still in the works, but in the meantime I was experimenting with using yarn v2/berry in one of my ember apps and it did not want to resolve the dependencies as they are.
By tweaking the URL to the new one, and using the full commit hash, I was able to get it to work and from my testing this seems to work fine with yarn v1 and v2.