TestFunctions() : TestFixture("TestFunctions") {}

Settings settings;

void run() override {

settings.severity.enable(Severity::style);

settings.severity.enable(Severity::warning);

settings.severity.enable(Severity::performance);

settings.severity.enable(Severity::portability);

settings.certainty.enable(Certainty::inconclusive);

settings.standards.c = Standards::C11;

settings.standards.cpp = Standards::CPP11;

LOAD_LIB_2(settings.library, "std.cfg");

LOAD_LIB_2(settings.library, "posix.cfg");

settings.libraries.emplace_back("posix");

// Prohibited functions

TEST_CASE(prohibitedFunctions_posix);

TEST_CASE(prohibitedFunctions_index);

TEST_CASE(prohibitedFunctions_qt_index); // FP when using the Qt function 'index'?

TEST_CASE(prohibitedFunctions_rindex);

TEST_CASE(prohibitedFunctions_var); // no false positives for variables

TEST_CASE(prohibitedFunctions_gets); // dangerous function

TEST_CASE(prohibitedFunctions_alloca);

TEST_CASE(prohibitedFunctions_declaredFunction); // declared function ticket #3121

TEST_CASE(prohibitedFunctions_std_gets); // test std::gets

TEST_CASE(prohibitedFunctions_multiple); // multiple use of obsolete functions

TEST_CASE(prohibitedFunctions_c_declaration); // c declared function

TEST_CASE(prohibitedFunctions_functionWithBody); // function with body

TEST_CASE(prohibitedFunctions_crypt); // Non-reentrant function

TEST_CASE(prohibitedFunctions_namespaceHandling);

// Invalid function usage

TEST_CASE(invalidFunctionUsage1);

TEST_CASE(invalidFunctionUsageStrings);

// Math function usage

TEST_CASE(mathfunctionCall_fmod);

TEST_CASE(mathfunctionCall_sqrt);

TEST_CASE(mathfunctionCall_log);

TEST_CASE(mathfunctionCall_acos);

TEST_CASE(mathfunctionCall_asin);

TEST_CASE(mathfunctionCall_pow);

TEST_CASE(mathfunctionCall_atan2);

TEST_CASE(mathfunctionCall_precision);

// Ignored return value

TEST_CASE(checkIgnoredReturnValue);

TEST_CASE(checkIgnoredErrorCode);

// memset..

TEST_CASE(memsetZeroBytes);

TEST_CASE(memsetInvalid2ndParam);

// missing "return"

TEST_CASE(checkMissingReturn);

// std::move for locar variable

TEST_CASE(returnLocalStdMove1);

TEST_CASE(returnLocalStdMove2);

TEST_CASE(returnLocalStdMove3);

TEST_CASE(returnLocalStdMove4);

TEST_CASE(returnLocalStdMove5);

TEST_CASE(negativeMemoryAllocationSizeError); // #389

TEST_CASE(checkLibraryMatchFunctions);

TEST_CASE(checkUseStandardLibrary1);

TEST_CASE(checkUseStandardLibrary2);

TEST_CASE(checkUseStandardLibrary3);

TEST_CASE(checkUseStandardLibrary4);

TEST_CASE(checkUseStandardLibrary5);

TEST_CASE(checkUseStandardLibrary6);

TEST_CASE(checkUseStandardLibrary7);

TEST_CASE(checkUseStandardLibrary8);

TEST_CASE(checkUseStandardLibrary9);

TEST_CASE(checkUseStandardLibrary10);

TEST_CASE(checkUseStandardLibrary11);

TEST_CASE(checkUseStandardLibrary12);

TEST_CASE(checkUseStandardLibrary13);

TEST_CASE(checkUseStandardLibrary14);

}

#define check(...) check_(__FILE__, __LINE__, __VA_ARGS__)

void check_(const char* file, int line, const char code[], const char filename[] = "test.cpp", const Settings* settings_ = nullptr) {

// Clear the error buffer..

errout.str("");

if (!settings_)

settings_ = &settings;

// Tokenize..

Tokenizer tokenizer(settings_, this);

std::istringstream istr(code);

ASSERT_LOC(tokenizer.tokenize(istr, filename), file, line);

runChecks<CheckFunctions>(&tokenizer, settings_, this);

}

void prohibitedFunctions_posix() {

check("void f()\n"

"{\n"

" bsd_signal(SIGABRT, SIG_IGN);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (style) Obsolescent function 'bsd_signal' called. It is recommended to use 'sigaction' instead.\n", errout.str());

check("int f()\n"

"{\n"

" int bsd_signal(0);\n"

" return bsd_signal;\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void f()\n"

"{\n"

" struct hostent *hp;\n"

" if(!hp = gethostbyname(\"127.0.0.1\")) {\n"

" exit(1);\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (style) Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead.\n", errout.str());

check("void f()\n"

"{\n"

" long addr;\n"

" addr = inet_addr(\"127.0.0.1\");\n"

" if(!hp = gethostbyaddr((char *) &addr, sizeof(addr), AF_INET)) {\n"

" exit(1);\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (style) Obsolescent function 'gethostbyaddr' called. It is recommended to use 'getnameinfo' instead.\n", errout.str());

check("void f()\n"

"{\n"

" usleep( 1000 );\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (style) Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead.\n", errout.str());

}

void prohibitedFunctions_index() {

check("namespace n1 {\n"

" int index(){ return 1; };\n"

"}\n"

"int main()\n"

"{\n"

" n1::index();\n"

" return 0;\n"

"}");

ASSERT_EQUALS("", errout.str());

check("std::size_t f()\n"

"{\n"

" std::size_t index(0);\n"

" index++;\n"

" return index;\n"

"}");

ASSERT_EQUALS("", errout.str());

check("int f()\n"

"{\n"

" return this->index();\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void f()\n"

"{\n"

" int index( 0 );\n"

"}");

ASSERT_EQUALS("", errout.str());

check("const char f()\n"

"{\n"

" const char var[6] = \"index\";\n"

" const char i = index(var, 0);\n"

" return i;\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (style) Obsolescent function 'index' called. It is recommended to use 'strchr' instead.\n",

errout.str());

}

void prohibitedFunctions_qt_index() {

check("void TDataModel::forceRowRefresh(int row) {\n"

" emit dataChanged(index(row, 0), index(row, columnCount() - 1));\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (style) Obsolescent function 'index' called. It is recommended to use 'strchr' instead.\n", errout.str());

}

void prohibitedFunctions_rindex() {

check("void f()\n"

"{\n"

" int rindex( 0 );\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void f()\n"

"{\n"

" const char var[7] = \"rindex\";\n"

" print(rindex(var, 0));\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (style) Obsolescent function 'rindex' called. It is recommended to use 'strrchr' instead.\n", errout.str());

}

void prohibitedFunctions_var() {

check("class Fred {\n"

"public:\n"

" Fred() : index(0) { }\n"

" int index;\n"

"};");

ASSERT_EQUALS("", errout.str());

}

void prohibitedFunctions_gets() {

check("void f()\n"

"{\n"

" char *x = gets(a);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.\n", errout.str());

check("void f()\n"

"{\n"

" foo(x, gets(a));\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.\n", errout.str());

}

void prohibitedFunctions_alloca() {

check("void f()\n"

"{\n"

" char *x = alloca(10);\n"

"}", "test.cpp"); // #4382 - there are no VLAs in C++

ASSERT_EQUALS("[test.cpp:3]: (warning) Obsolete function 'alloca' called.\n", errout.str());

check("void f()\n"

"{\n"

" char *x = alloca(10);\n"

"}", "test.c");

ASSERT_EQUALS("[test.c:3]: (warning) Obsolete function 'alloca' called. In C99 and later it is recommended to use a variable length array instead.\n", errout.str());

settings.standards.c = Standards::C89;

settings.standards.cpp = Standards::CPP03;

check("void f()\n"

"{\n"

" char *x = alloca(10);\n"

"}", "test.cpp"); // #4382 - there are no VLAs in C++

ASSERT_EQUALS("", errout.str());

check("void f()\n"

"{\n"

" char *x = alloca(10);\n"

"}", "test.c"); // #7558 - no alternative to alloca in C89

ASSERT_EQUALS("", errout.str());

check("void f()\n"

"{\n"

" char *x = alloca(10);\n"

"}", "test.c");

ASSERT_EQUALS("", errout.str());

settings.standards.c = Standards::C11;

settings.standards.cpp = Standards::CPP11;

}

// ticket #3121

void prohibitedFunctions_declaredFunction() {

check("int ftime ( int a )\n"

"{\n"

" return a;\n"

"}\n"

"int main ()\n"

"{\n"

" int b ; b = ftime ( 1 ) ;\n"

" return 0 ;\n"

"}");

ASSERT_EQUALS("", errout.str());

}

// test std::gets

void prohibitedFunctions_std_gets() {

check("void f(char * str)\n"

"{\n"

" char *x = std::gets(str);\n"

" char *y = gets(str);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.\n"

"[test.cpp:4]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.\n", errout.str());

}

// multiple use

void prohibitedFunctions_multiple() {

check("void f(char * str)\n"

"{\n"

" char *x = std::gets(str);\n"

" usleep( 1000 );\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.\n"

"[test.cpp:4]: (style) Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead.\n", errout.str());

}

void prohibitedFunctions_c_declaration() {

check("char * gets ( char * c ) ;\n"

"int main ()\n"

"{\n"

" char s [ 10 ] ;\n"

" gets ( s ) ;\n"

" return 0;\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.\n", errout.str());

check("int getcontext(ucontext_t *ucp);\n"

"void f (ucontext_t *ucp)\n"

"{\n"

" getcontext ( ucp ) ;\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (portability) Obsolescent function 'getcontext' called. Applications are recommended to be rewritten to use POSIX threads.\n", errout.str());

}

void prohibitedFunctions_functionWithBody() {

check("char * gets ( char * c ) { return c; }\n"

"int main ()\n"

"{\n"

" char s [ 10 ] ;\n"

" gets ( s ) ;\n"

" return 0;\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void prohibitedFunctions_crypt() {

check("void f(char *pwd)\n"

"{\n"

" char *cpwd;"

" crypt(pwd, cpwd);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Return value of function crypt() is not used.\n"

"[test.cpp:3]: (portability) Non reentrant function 'crypt' called. For threadsafe applications it is recommended to use the reentrant replacement function 'crypt_r'.\n", errout.str());

check("void f()\n"

"{\n"

" char *pwd = getpass(\"Password:\");"

" char *cpwd;"

" crypt(pwd, cpwd);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Return value of function crypt() is not used.\n"

"[test.cpp:3]: (portability) Non reentrant function 'crypt' called. For threadsafe applications it is recommended to use the reentrant replacement function 'crypt_r'.\n", errout.str());

check("int f()\n"

"{\n"

" int crypt = 0;"

" return crypt;\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void prohibitedFunctions_namespaceHandling() {

check("void f()\n"

"{\n"

" time_t t = 0;"

" auto lt = std::localtime(&t);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (portability) Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'.\n", errout.str());

// Passed as function argument

check("void f()\n"

"{\n"

" printf(\"Magic guess: %d\", getpwent());\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (portability) Non reentrant function 'getpwent' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwent_r'.\n", errout.str());

// Pass return value

check("void f()\n"

"{\n"

" time_t t = 0;"

" struct tm *foo = localtime(&t);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (portability) Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'.\n", errout.str());

// Access via global namespace

check("void f()\n"

"{\n"

" ::getpwent();\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Return value of function getpwent() is not used.\n"

"[test.cpp:3]: (portability) Non reentrant function 'getpwent' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwent_r'.\n", errout.str());

// Be quiet on function definitions

check("int getpwent()\n"

"{\n"

" return 123;\n"

"}");

ASSERT_EQUALS("", errout.str());

// Be quiet on other namespaces

check("void f()\n"

"{\n"

" foobar::getpwent();\n"

"}");

ASSERT_EQUALS("", errout.str());

// Be quiet on class member functions

check("void f()\n"

"{\n"

" foobar.getpwent();\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void invalidFunctionUsage1() {

check("void f() { memset(a,b,sizeof(a)!=12); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

check("void f() { memset(a,b,sizeof(a)!=0); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

check("void f() { memset(a,b,!c); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

// Ticket #6990

check("void f(bool c) { memset(a,b,c); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

check("void f() { memset(a,b,true); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

// Ticket #6588 (c mode)

check("void record(char* buf, int n) {\n"

" memset(buf, 0, n < 255);\n" /* KO */

" memset(buf, 0, n < 255 ? n : 255);\n" /* OK */

"}", "test.c");

ASSERT_EQUALS("[test.c:2]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

// Ticket #6588 (c++ mode)

check("void record(char* buf, int n) {\n"

" memset(buf, 0, n < 255);\n" /* KO */

" memset(buf, 0, n < 255 ? n : 255);\n" /* OK */

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid memset() argument nr 3. A non-boolean value is required.\n", errout.str());

check("int boolArgZeroIsInvalidButOneIsValid(int a, int param) {\n"

" return div(a, param > 0);\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid div() argument nr 2. The value is 0 or 1 (boolean) but the valid values are ':-1,1:'.\n", errout.str());

check("void boolArgZeroIsValidButOneIsInvalid(int param) {\n"

" strtol(a, b, param > 0);\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid strtol() argument nr 3. The value is 0 or 1 (boolean) but the valid values are '0,2:36'.\n", errout.str());

check("void f() { strtol(a,b,1); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strtol() argument nr 3. The value is 1 but the valid values are '0,2:36'.\n", errout.str());

check("void f() { strtol(a,b,10); }");

ASSERT_EQUALS("", errout.str());

check("void f(std::vector<int>& v) {\n" // #10754

" int N = -1;\n"

" for (long i = 0; i < g(); i++)\n"

" N = h(N);\n"

" v.resize(N);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:5]: (warning) Invalid v.resize() argument nr 1. The value is -1 but the valid values are '0:'.\n", errout.str());

check("void f(std::vector<int>& v, int N) {\n"

" if (N < -1)\n"

" return;\n"

" v.resize(N);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:4]: (warning) Either the condition 'N<-1' is redundant or v.resize() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'.\n",

errout.str());

check("void f(std::vector<int>& v, int N) {\n"

" if (N == -1) {}\n"

" v.resize(N);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (warning) Either the condition 'N==-1' is redundant or v.resize() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'.\n",

errout.str());

check("void f(std::vector<int>& v, int N, bool b) {\n"

" if (b)\n"

" N = -1;\n"

" v.resize(N);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:4]: (warning) Invalid v.resize() argument nr 1. The value is -1 but the valid values are '0:'.\n",

errout.str());

check("void f(std::vector<int>& v) {\n"

" int N = -1;\n"

" v.resize(N);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid v.resize() argument nr 1. The value is -1 but the valid values are '0:'.\n",

errout.str());

}

void invalidFunctionUsageStrings() {

check("size_t f() { char x = 'x'; return strlen(&x); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("size_t f() { return strlen(&x); }");

ASSERT_EQUALS("", errout.str());

check("size_t f(char x) { return strlen(&x); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("size_t f() { char x = '\\0'; return strlen(&x); }");

ASSERT_EQUALS("", errout.str());

check("size_t f() {\n"

" char x;\n"

" if (y)\n"

" x = '\\0';\n"

" else\n"

" x = 'a';\n"

" return strlen(&x);\n"

"}");

ASSERT_EQUALS("[test.cpp:7]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("int f() { char x = '\\0'; return strcmp(\"Hello world\", &x); }");

ASSERT_EQUALS("", errout.str());

check("int f() { char x = 'x'; return strcmp(\"Hello world\", &x); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strcmp() argument nr 2. A nul-terminated string is required.\n", errout.str());

check("size_t f(char x) { char * y = &x; return strlen(y); }");

TODO_ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", "", errout.str());

check("size_t f(char x) { char * y = &x; char *z = y; return strlen(z); }");

TODO_ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", "", errout.str());

check("size_t f() { char x = 'x'; char * y = &x; char *z = y; return strlen(z); }");

TODO_ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", "", errout.str());

check("size_t f() { char x = '\\0'; char * y = &x; char *z = y; return strlen(z); }");

ASSERT_EQUALS("", errout.str());

check("size_t f() { char x[] = \"Hello world\"; return strlen(x); }");

ASSERT_EQUALS("", errout.str());

check("size_t f(char x[]) { return strlen(x); }");

ASSERT_EQUALS("", errout.str());

check("int f(char x, char y) { return strcmp(&x, &y); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strcmp() argument nr 1. A nul-terminated string is required.\n"

"[test.cpp:1]: (error) Invalid strcmp() argument nr 2. A nul-terminated string is required.\n", errout.str());

check("size_t f() { char x[] = \"Hello world\"; return strlen(&x[0]); }");

ASSERT_EQUALS("", errout.str());

check("size_t f() { char* x = \"Hello world\"; return strlen(&x[0]); }");

ASSERT_EQUALS("", errout.str());

check("struct S {\n"

" char x;\n"

"};\n"

"size_t f() {\n"

" S s1 = {0};\n"

" S s2;\n;"

" s2.x = 'x';\n"

" size_t l1 = strlen(&s1.x);\n"

" size_t l2 = strlen(&s2.x);\n"

" return l1 + l2;\n"

"}");

ASSERT_EQUALS("[test.cpp:8]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n"

"[test.cpp:9]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("const char x = 'x'; size_t f() { return strlen(&x); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("struct someStruct {\n"

" union {\n"

" struct {\n"

" uint16_t nr;\n"

" uint8_t d[40];\n"

" } data;\n"

" char buf[42];\n"

" } x;\n"

"};\n"

"int f(struct someStruct * const tp, const int k)\n"

"{\n"

" return strcmp(&tp->x.buf[k], \"needle\");\n"

"}");

ASSERT_EQUALS("", errout.str());

check("struct someStruct {\n"

" char buf[42];\n"

"};\n"

"int f(struct someStruct * const tp, const int k)\n"

"{\n"

" return strcmp(&tp->buf[k], \"needle\");\n"

"}");

ASSERT_EQUALS("", errout.str());

check("const char x = 'x'; size_t f() { char y = x; return strlen(&y); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("const char x = '\\0'; size_t f() { return strlen(&x); }");

ASSERT_EQUALS("", errout.str());

check("const char x = '\\0'; size_t f() { char y = x; return strlen(&y); }");

ASSERT_EQUALS("", errout.str());

check("size_t f() {\n"

" char * a = \"Hello world\";\n"

" char ** b = &a;\n"

" return strlen(&b[0][0]);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("size_t f() {\n"

" char ca[] = \"asdf\";\n"

" return strlen((char*) &ca);\n"

"}");

ASSERT_EQUALS("", errout.str());

// #5225

check("int main(void)\n"

"{\n"

" char str[80] = \"hello worl\";\n"

" char d = 'd';\n"

" strcat(str, &d);\n"

" puts(str);\n"

" return 0;\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Invalid strcat() argument nr 2. A nul-terminated string is required.\n", errout.str());

check("FILE* f(void) {\n"

" const char fileName[1] = { \'x\' };\n"

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid fopen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("FILE* f(void) {\n"

" const char fileName[2] = { \'x\', \'y\' };\n"

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid fopen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("FILE* f(void) {\n"

" const char fileName[3] = { \'x\', \'y\' ,\'\\0\' };\n"

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("", errout.str());

check("FILE* f(void) {\n"

" const char fileName[3] = { \'x\', \'\\0\' ,\'y\' };\n"

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("", errout.str());

check("FILE* f(void) {\n"

" const char fileName[3] = { \'x\', \'y\' };\n" // implicit '\0' added at the end

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("", errout.str());

check("FILE* f(void) {\n"

" const char fileName[] = { \'\\0\' };\n"

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("", errout.str());

check("FILE* f(void) {\n"

" const char fileName[] = { \'0\' + 42 };\n" // no size is explicitly defined, no implicit '\0' is added

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid fopen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("FILE* f(void) {\n"

" const char fileName[] = { \'0\' + 42, \'x\' };\n" // no size is explicitly defined, no implicit '\0' is added

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid fopen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("FILE* f(void) {\n"

" const char fileName[2] = { \'0\' + 42 };\n" // implicitly '\0' added at the end because size is set to 2

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("", errout.str());

check("FILE* f(void) {\n"

" const char fileName[] = { };\n"

" return fopen(fileName, \"r\"); \n"

"}");

ASSERT_EQUALS("", errout.str());

check("void scanMetaTypes()\n" // don't crash

"{\n"

" QVector<int> metaTypes;\n"

" for (int mtId = 0; mtId <= QMetaType::User; ++mtId) {\n"

" const auto name = QMetaType::typeName(mtId);\n"

" if (strstr(name, \"GammaRay::\") != name)\n"

" metaTypes.push_back(mtId);\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

check("int f() {\n"

" const char c[3] = \"abc\";\n"

" return strlen(c);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid strlen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("int f() {\n"

" const wchar_t c[3] = L\"abc\";\n"

" return wcslen(c);\n"

"}\n");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid wcslen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("void f(char* dest) {\n"

" char if_name[(IF_NAMESIZE > 21 ? IF_NAMESIZE : 21) + 1] = \"%\";\n"

" strcat(dest, if_name);\n"

"}\n");

ASSERT_EQUALS("", errout.str());

check("int f() {\n"

" const char c[3] = \"ab\\0\";\n"

" return strlen(c);\n"

"}\n");

ASSERT_EQUALS("", errout.str());

check("void f(int n) {\n" // #11179

" char s[8] = \" \";\n"

" n = (n + 1) % 100;\n"

" sprintf(s, \"lwip%02d\", n);\n"

" s[strlen(s)] = ' ';\n"

"}\n");

ASSERT_EQUALS("", errout.str());

check("size_t f() { wchar_t x = L'x'; return wcslen(&x); }");

ASSERT_EQUALS("[test.cpp:1]: (error) Invalid wcslen() argument nr 1. A nul-terminated string is required.\n", errout.str());

check("void f() { char a[10] = \"1234567890\"; puts(a); }", "test.c"); // #1770

ASSERT_EQUALS("[test.c:1]: (error) Invalid puts() argument nr 1. A nul-terminated string is required.\n", errout.str());

}

void mathfunctionCall_sqrt() {

// sqrt, sqrtf, sqrtl

check("void foo()\n"

"{\n"

" std::cout << sqrt(-1) << std::endl;\n"

" std::cout << sqrtf(-1) << std::endl;\n"

" std::cout << sqrtl(-1) << std::endl;\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid sqrt() argument nr 1. The value is -1 but the valid values are '0.0:'.\n"

"[test.cpp:4]: (error) Invalid sqrtf() argument nr 1. The value is -1 but the valid values are '0.0:'.\n"

"[test.cpp:5]: (error) Invalid sqrtl() argument nr 1. The value is -1 but the valid values are '0.0:'.\n", errout.str());

// implementation-defined behaviour for "finite values of x<0" only:

check("void foo()\n"

"{\n"

" std::cout << sqrt(-0.) << std::endl;\n"

" std::cout << sqrtf(-0.) << std::endl;\n"

" std::cout << sqrtl(-0.) << std::endl;\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo()\n"

"{\n"

" std::cout << sqrt(1) << std::endl;\n"

" std::cout << sqrtf(1) << std::endl;\n"

" std::cout << sqrtl(1) << std::endl;\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void mathfunctionCall_log() {

// log,log10,logf,logl,log10f,log10l,log2,log2f,log2l,log1p,log1pf,log1pl

check("void foo()\n"

"{\n"

" std::cout << log(-2) << std::endl;\n"

" std::cout << logf(-2) << std::endl;\n"

" std::cout << logl(-2) << std::endl;\n"

" std::cout << log10(-2) << std::endl;\n"

" std::cout << log10f(-2) << std::endl;\n"

" std::cout << log10l(-2) << std::endl;\n"

" std::cout << log2(-2) << std::endl;\n"

" std::cout << log2f(-2) << std::endl;\n"

" std::cout << log2l(-2) << std::endl;\n"

" std::cout << log1p(-3) << std::endl;\n"

" std::cout << log1pf(-3) << std::endl;\n"

" std::cout << log1pl(-3) << std::endl;\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid log() argument nr 1. The value is -2 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:4]: (error) Invalid logf() argument nr 1. The value is -2 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:5]: (error) Invalid logl() argument nr 1. The value is -2 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:6]: (error) Invalid log10() argument nr 1. The value is -2 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:7]: (error) Invalid log10f() argument nr 1. The value is -2 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:8]: (error) Invalid log10l() argument nr 1. The value is -2 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:9]: (error) Invalid log2() argument nr 1. The value is -2 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:10]: (error) Invalid log2f() argument nr 1. The value is -2 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:11]: (error) Invalid log2l() argument nr 1. The value is -2 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:3]: (warning) Passing value -2 to log() leads to implementation-defined result.\n"

"[test.cpp:4]: (warning) Passing value -2 to logf() leads to implementation-defined result.\n"

"[test.cpp:5]: (warning) Passing value -2 to logl() leads to implementation-defined result.\n"

"[test.cpp:6]: (warning) Passing value -2 to log10() leads to implementation-defined result.\n"

"[test.cpp:7]: (warning) Passing value -2 to log10f() leads to implementation-defined result.\n"

"[test.cpp:8]: (warning) Passing value -2 to log10l() leads to implementation-defined result.\n"

"[test.cpp:9]: (warning) Passing value -2 to log2() leads to implementation-defined result.\n"

"[test.cpp:10]: (warning) Passing value -2 to log2f() leads to implementation-defined result.\n"

"[test.cpp:11]: (warning) Passing value -2 to log2l() leads to implementation-defined result.\n"

"[test.cpp:12]: (warning) Passing value -3 to log1p() leads to implementation-defined result.\n"

"[test.cpp:13]: (warning) Passing value -3 to log1pf() leads to implementation-defined result.\n"

"[test.cpp:14]: (warning) Passing value -3 to log1pl() leads to implementation-defined result.\n", errout.str());

check("void foo()\n"

"{\n"

" std::cout << log(-1) << std::endl;\n"

" std::cout << logf(-1) << std::endl;\n"

" std::cout << logl(-1) << std::endl;\n"

" std::cout << log10(-1) << std::endl;\n"

" std::cout << log10f(-1) << std::endl;\n"

" std::cout << log10l(-1) << std::endl;\n"

" std::cout << log2(-1) << std::endl;\n"

" std::cout << log2f(-1) << std::endl;\n"

" std::cout << log2l(-1) << std::endl;\n"

" std::cout << log1p(-2) << std::endl;\n"

" std::cout << log1pf(-2) << std::endl;\n"

" std::cout << log1pl(-2) << std::endl;\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid log() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:4]: (error) Invalid logf() argument nr 1. The value is -1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:5]: (error) Invalid logl() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:6]: (error) Invalid log10() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:7]: (error) Invalid log10f() argument nr 1. The value is -1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:8]: (error) Invalid log10l() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:9]: (error) Invalid log2() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:10]: (error) Invalid log2f() argument nr 1. The value is -1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:11]: (error) Invalid log2l() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:3]: (warning) Passing value -1 to log() leads to implementation-defined result.\n"

"[test.cpp:4]: (warning) Passing value -1 to logf() leads to implementation-defined result.\n"

"[test.cpp:5]: (warning) Passing value -1 to logl() leads to implementation-defined result.\n"

"[test.cpp:6]: (warning) Passing value -1 to log10() leads to implementation-defined result.\n"

"[test.cpp:7]: (warning) Passing value -1 to log10f() leads to implementation-defined result.\n"

"[test.cpp:8]: (warning) Passing value -1 to log10l() leads to implementation-defined result.\n"

"[test.cpp:9]: (warning) Passing value -1 to log2() leads to implementation-defined result.\n"

"[test.cpp:10]: (warning) Passing value -1 to log2f() leads to implementation-defined result.\n"

"[test.cpp:11]: (warning) Passing value -1 to log2l() leads to implementation-defined result.\n"

"[test.cpp:12]: (warning) Passing value -2 to log1p() leads to implementation-defined result.\n"

"[test.cpp:13]: (warning) Passing value -2 to log1pf() leads to implementation-defined result.\n"

"[test.cpp:14]: (warning) Passing value -2 to log1pl() leads to implementation-defined result.\n", errout.str());

check("void foo()\n"

"{\n"

" std::cout << log(-1.0) << std::endl;\n"

" std::cout << logf(-1.0) << std::endl;\n"

" std::cout << logl(-1.0) << std::endl;\n"

" std::cout << log10(-1.0) << std::endl;\n"

" std::cout << log10f(-1.0) << std::endl;\n"

" std::cout << log10l(-1.0) << std::endl;\n"

" std::cout << log2(-1.0) << std::endl;\n"

" std::cout << log2f(-1.0) << std::endl;\n"

" std::cout << log2l(-1.0) << std::endl;\n"

" std::cout << log1p(-2.0) << std::endl;\n"

" std::cout << log1pf(-2.0) << std::endl;\n"

" std::cout << log1pl(-2.0) << std::endl;\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid log() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:4]: (error) Invalid logf() argument nr 1. The value is -1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:5]: (error) Invalid logl() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:6]: (error) Invalid log10() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:7]: (error) Invalid log10f() argument nr 1. The value is -1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:8]: (error) Invalid log10l() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:9]: (error) Invalid log2() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:10]: (error) Invalid log2f() argument nr 1. The value is -1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:11]: (error) Invalid log2l() argument nr 1. The value is -1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:3]: (warning) Passing value -1.0 to log() leads to implementation-defined result.\n"

"[test.cpp:4]: (warning) Passing value -1.0 to logf() leads to implementation-defined result.\n"

"[test.cpp:5]: (warning) Passing value -1.0 to logl() leads to implementation-defined result.\n"

"[test.cpp:6]: (warning) Passing value -1.0 to log10() leads to implementation-defined result.\n"

"[test.cpp:7]: (warning) Passing value -1.0 to log10f() leads to implementation-defined result.\n"

"[test.cpp:8]: (warning) Passing value -1.0 to log10l() leads to implementation-defined result.\n"

"[test.cpp:9]: (warning) Passing value -1.0 to log2() leads to implementation-defined result.\n"

"[test.cpp:10]: (warning) Passing value -1.0 to log2f() leads to implementation-defined result.\n"

"[test.cpp:11]: (warning) Passing value -1.0 to log2l() leads to implementation-defined result.\n"

"[test.cpp:12]: (warning) Passing value -2.0 to log1p() leads to implementation-defined result.\n"

"[test.cpp:13]: (warning) Passing value -2.0 to log1pf() leads to implementation-defined result.\n"

"[test.cpp:14]: (warning) Passing value -2.0 to log1pl() leads to implementation-defined result.\n", errout.str());

check("void foo()\n"

"{\n"

" std::cout << log(-0.1) << std::endl;\n"

" std::cout << logf(-0.1) << std::endl;\n"

" std::cout << logl(-0.1) << std::endl;\n"

" std::cout << log10(-0.1) << std::endl;\n"

" std::cout << log10f(-0.1) << std::endl;\n"

" std::cout << log10l(-0.1) << std::endl;\n"

" std::cout << log2(-0.1) << std::endl;\n"

" std::cout << log2f(-0.1) << std::endl;\n"

" std::cout << log2l(-0.1) << std::endl;\n"

" std::cout << log1p(-1.1) << std::endl;\n"

" std::cout << log1pf(-1.1) << std::endl;\n"

" std::cout << log1pl(-1.1) << std::endl;\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid log() argument nr 1. The value is -0.1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:4]: (error) Invalid logf() argument nr 1. The value is -0.1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:5]: (error) Invalid logl() argument nr 1. The value is -0.1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:6]: (error) Invalid log10() argument nr 1. The value is -0.1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:7]: (error) Invalid log10f() argument nr 1. The value is -0.1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:8]: (error) Invalid log10l() argument nr 1. The value is -0.1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:9]: (error) Invalid log2() argument nr 1. The value is -0.1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:10]: (error) Invalid log2f() argument nr 1. The value is -0.1 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:11]: (error) Invalid log2l() argument nr 1. The value is -0.1 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:3]: (warning) Passing value -0.1 to log() leads to implementation-defined result.\n"

"[test.cpp:4]: (warning) Passing value -0.1 to logf() leads to implementation-defined result.\n"

"[test.cpp:5]: (warning) Passing value -0.1 to logl() leads to implementation-defined result.\n"

"[test.cpp:6]: (warning) Passing value -0.1 to log10() leads to implementation-defined result.\n"

"[test.cpp:7]: (warning) Passing value -0.1 to log10f() leads to implementation-defined result.\n"

"[test.cpp:8]: (warning) Passing value -0.1 to log10l() leads to implementation-defined result.\n"

"[test.cpp:9]: (warning) Passing value -0.1 to log2() leads to implementation-defined result.\n"

"[test.cpp:10]: (warning) Passing value -0.1 to log2f() leads to implementation-defined result.\n"

"[test.cpp:11]: (warning) Passing value -0.1 to log2l() leads to implementation-defined result.\n"

"[test.cpp:12]: (warning) Passing value -1.1 to log1p() leads to implementation-defined result.\n"

"[test.cpp:13]: (warning) Passing value -1.1 to log1pf() leads to implementation-defined result.\n"

"[test.cpp:14]: (warning) Passing value -1.1 to log1pl() leads to implementation-defined result.\n", errout.str());

check("void foo()\n"

"{\n"

" std::cout << log(0) << std::endl;\n"

" std::cout << logf(0.) << std::endl;\n"

" std::cout << logl(0.0) << std::endl;\n"

" std::cout << log10(0.0) << std::endl;\n"

" std::cout << log10f(0) << std::endl;\n"

" std::cout << log10l(0.) << std::endl;\n"

" std::cout << log2(0.) << std::endl;\n"

" std::cout << log2f(0.0) << std::endl;\n"

" std::cout << log2l(0) << std::endl;\n"

" std::cout << log1p(-1.) << std::endl;\n"

" std::cout << log1pf(-1.0) << std::endl;\n"

" std::cout << log1pl(-1) << std::endl;\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:4]: (error) Invalid logf() argument nr 1. The value is 0 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:5]: (error) Invalid logl() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:6]: (error) Invalid log10() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:7]: (error) Invalid log10f() argument nr 1. The value is 0 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:8]: (error) Invalid log10l() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:9]: (error) Invalid log2() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:10]: (error) Invalid log2f() argument nr 1. The value is 0 but the valid values are '1.4013e-45:'.\n"

"[test.cpp:11]: (error) Invalid log2l() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'.\n"

"[test.cpp:3]: (warning) Passing value 0 to log() leads to implementation-defined result.\n"

"[test.cpp:4]: (warning) Passing value 0. to logf() leads to implementation-defined result.\n"

"[test.cpp:5]: (warning) Passing value 0.0 to logl() leads to implementation-defined result.\n"

"[test.cpp:6]: (warning) Passing value 0.0 to log10() leads to implementation-defined result.\n"

"[test.cpp:7]: (warning) Passing value 0 to log10f() leads to implementation-defined result.\n"

"[test.cpp:8]: (warning) Passing value 0. to log10l() leads to implementation-defined result.\n"

"[test.cpp:9]: (warning) Passing value 0. to log2() leads to implementation-defined result.\n"

"[test.cpp:10]: (warning) Passing value 0.0 to log2f() leads to implementation-defined result.\n"

"[test.cpp:11]: (warning) Passing value 0 to log2l() leads to implementation-defined result.\n"

"[test.cpp:12]: (warning) Passing value -1. to log1p() leads to implementation-defined result.\n"

"[test.cpp:13]: (warning) Passing value -1.0 to log1pf() leads to implementation-defined result.\n"

"[test.cpp:14]: (warning) Passing value -1 to log1pl() leads to implementation-defined result.\n", errout.str());

check("void foo()\n"

"{\n"

" std::cout << log(1E-3) << std::endl;\n"

" std::cout << logf(1E-3) << std::endl;\n"

" std::cout << logl(1E-3) << std::endl;\n"

" std::cout << log10(1E-3) << std::endl;\n"

" std::cout << log10f(1E-3) << std::endl;\n"

" std::cout << log10l(1E-3) << std::endl;\n"

" std::cout << log2(1E-3) << std::endl;\n"

" std::cout << log2f(1E-3) << std::endl;\n"

" std::cout << log2l(1E-3) << std::endl;\n"

" std::cout << log1p(-1+1E-3) << std::endl;\n"

" std::cout << log1pf(-1+1E-3) << std::endl;\n"

" std::cout << log1pl(-1+1E-3) << std::endl;\n"

" std::cout << log(1.0E-3) << std::endl;\n"

" std::cout << logf(1.0E-3) << std::endl;\n"