build fix

sadasant · sadasant · commit e6ccacf29a93 · 2019-08-21T00:16:19.000Z
diff --git a/apps/rush-lib/src/cli/actions/AddAction.ts b/apps/rush-lib/src/cli/actions/AddAction.ts
@@ -16,6 +16,7 @@ import { PackageJsonUpdater, SemVerStyle } from '../../logic/PackageJsonUpdater'
 import { PackageName } from '@microsoft/node-core-library';
 
 export class AddAction extends BaseRushAction {
+  private _allFlag: CommandLineFlagParameter;
   private _exactFlag: CommandLineFlagParameter;
   private _caretFlag: CommandLineFlagParameter;
   private _devDependencyFlag: CommandLineFlagParameter;
@@ -85,7 +86,7 @@ export class AddAction extends BaseRushAction {
     });
   }
 
-  public run(): Promise<void> {
+  public async run(): Promise<void> {
     const currentProject: RushConfigurationProject | undefined = this.rushConfiguration.tryGetProjectForPath(
       process.cwd()
     );
@@ -122,13 +123,15 @@ export class AddAction extends BaseRushAction {
 
     let projects: RushConfigurationProject[];
     if (this._allFlag) {
-      projects = Object.values(this._rushConfiguration.projectsByName);
+      projects = this.rushConfiguration.projects;
     } else {
       projects = [currentProject];
     }
 
+    const updater: PackageJsonUpdater = new PackageJsonUpdater(this.rushConfiguration, this.rushGlobalFolder);
+
     for (const project of projects) {
-      return new PackageJsonUpdater(this.rushConfiguration, this.rushGlobalFolder).doRushAdd({
+      await updater.doRushAdd({
         currentProject: project,
         packageName: packageName,
         initialVersion: version,
@@ -140,5 +143,7 @@ export class AddAction extends BaseRushAction {
           : (this._exactFlag.value ? SemVerStyle.Exact : SemVerStyle.Tilde)
       });
     }
+
+    return;
   }
 }
diff --git a/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap b/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap
@@ -54,7 +54,7 @@ For detailed help about a specific command, use: rush <command> -h
 `;
 
 exports[`CommandLineHelp prints the help for each action: add 1`] = `
-"usage: rush add [-h] -p PACKAGE [--exact] [--caret] [--dev] [-m] [-s]
+"usage: rush add [-h] -p PACKAGE [--exact] [--caret] [--dev] [-m] [-s] [--all]
 
 Adds a specified package as a dependency of the current project (as 
 determined by the current working directory) and then runs \\"rush update\\". If 
@@ -90,6 +90,8 @@ Optional arguments:
                         same version of the dependency.
   -s, --skip-update     If specified, the \\"rush update\\" command will not be 
                         run after updating the package.json files.
+  --all                 If specified, the dependency will be added to all of 
+                        your projects.
 "
 `;
 
