adding check to run() to make sure pack and apply-git-tags-on-pack are used together

chaseholland · chaseholland · commit d83ff1a02f66 · 2019-08-29T15:48:02.000-07:00
diff --git a/apps/rush-lib/src/cli/actions/PublishAction.ts b/apps/rush-lib/src/cli/actions/PublishAction.ts
@@ -233,6 +233,10 @@ export class PublishAction extends BaseRushAction {
     if (this._registryUrl.value && this._pack.value) {
       throw new Error(`--registry cannot be used with --pack`);
     }
+    if (this._applyGitTagsOnPack.value && !this._pack.value) {
+      throw new Error(`${this._applyGitTagsOnPack.longName} must be used `
+      + `with ${this._pack.longName}`);
+    }
   }
 
   private _publishChanges(allPackages: Map<string, RushConfigurationProject>): void {
diff --git a/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap b/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap
@@ -415,8 +415,8 @@ Optional arguments:
                         will be published with --force on npm
   --apply-git-tags-on-pack
                         If specified with --publish and --pack, git tags will 
-                        be applied for packages on pack as if a publish was 
-                        being run without --pack.
+                        be applied for packages as if a publish was being run 
+                        without --pack.
 "
 `;
 

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,10 @@ export class PublishAction extends BaseRushAction {`
`233`	`233`	`if (this._registryUrl.value && this._pack.value) {`
`234`	`234`	throw new Error(`--registry cannot be used with --pack`);
`235`	`235`	`}`
	`236`	`+ if (this._applyGitTagsOnPack.value && !this._pack.value) {`
	`237`	+ throw new Error(`${this._applyGitTagsOnPack.longName} must be used `
	`238`	+ + `with ${this._pack.longName}`);
	`239`	`+ }`
`236`	`240`	`}`
`237`	`241`
`238`	`242`	`private _publishChanges(allPackages: Map<string, RushConfigurationProject>): void {`