When we trim an entire symbol it says "Excluded from this release type", whereas when we trim a declaration it says "Excluded declaration from this release type"

octogonz · octogonz · commit ca2cf8899a74 · 2019-10-05T12:22:07.000-07:00
diff --git a/apps/api-extractor/src/generators/DtsRollupGenerator.ts b/apps/api-extractor/src/generators/DtsRollupGenerator.ts
@@ -88,9 +88,10 @@ export class DtsRollupGenerator {
         // For example, if the imported API comes from an external package that supports AEDoc,
         // and it was marked as `@internal`, then don't emit it.
         const symbolMetadata: SymbolMetadata | undefined = collector.tryFetchMetadataForAstEntity(astImport);
-        const releaseTag: ReleaseTag = symbolMetadata ? symbolMetadata.maxEffectiveReleaseTag : ReleaseTag.None;
+        const maxEffectiveReleaseTag: ReleaseTag = symbolMetadata
+          ? symbolMetadata.maxEffectiveReleaseTag : ReleaseTag.None;
 
-        if (this._shouldIncludeReleaseTag(releaseTag, dtsKind)) {
+        if (this._shouldIncludeReleaseTag(maxEffectiveReleaseTag, dtsKind)) {
           DtsEmitHelpers.emitImport(stringWriter, entity, astImport);
         }
       }
@@ -99,9 +100,10 @@ export class DtsRollupGenerator {
     // Emit the regular declarations
     for (const entity of collector.entities) {
       const symbolMetadata: SymbolMetadata | undefined = collector.tryFetchMetadataForAstEntity(entity.astEntity);
-      const releaseTag: ReleaseTag = symbolMetadata ? symbolMetadata.maxEffectiveReleaseTag : ReleaseTag.None;
+      const maxEffectiveReleaseTag: ReleaseTag = symbolMetadata
+        ? symbolMetadata.maxEffectiveReleaseTag : ReleaseTag.None;
 
-      if (!this._shouldIncludeReleaseTag(releaseTag, dtsKind)) {
+      if (!this._shouldIncludeReleaseTag(maxEffectiveReleaseTag, dtsKind)) {
         if (!collector.extractorConfig.omitTrimmingComments) {
           stringWriter.writeLine();
           stringWriter.writeLine(`/* Excluded from this release type: ${entity.nameForEmit} */`);
@@ -120,7 +122,7 @@ export class DtsRollupGenerator {
           ) {
               if (!collector.extractorConfig.omitTrimmingComments) {
                 stringWriter.writeLine();
-                stringWriter.writeLine(`/* Excluded from this release type: ${entity.nameForEmit} */`);
+                stringWriter.writeLine(`/* Excluded declaration from this release type: ${entity.nameForEmit} */`);
               }
               continue;
           } else {
diff --git a/build-tests/api-extractor-scenarios/etc/test-outputs/functionOverload/beta-rollup.d.ts b/build-tests/api-extractor-scenarios/etc/test-outputs/functionOverload/beta-rollup.d.ts
@@ -1,5 +1,5 @@
 
-/* Excluded from this release type: combine */
+/* Excluded declaration from this release type: combine */
 
 /**
  * @beta
@@ -16,7 +16,7 @@ export declare function combine(x: number, y: number): number;
  */
 export declare function _combine(x: string, y: string): string;
 
-/* Excluded from this release type: _combine */
+/* Excluded declaration from this release type: _combine */
 
 /**
  * @public
diff --git a/build-tests/api-extractor-scenarios/etc/test-outputs/functionOverload/public-rollup.d.ts b/build-tests/api-extractor-scenarios/etc/test-outputs/functionOverload/public-rollup.d.ts
@@ -1,7 +1,7 @@
 
-/* Excluded from this release type: combine */
+/* Excluded declaration from this release type: combine */
 
-/* Excluded from this release type: combine */
+/* Excluded declaration from this release type: combine */
 
 /**
  * @public
