Merge pull request microsoft#1595 from PissedCapslock/patch-1

octogonz · web-flow · commit 6d34b93dba86 · 2019-11-04T14:25:44.000-08:00
[api-extractor] Clarified the error message
diff --git a/apps/api-extractor-model/src/mixins/ApiItemContainerMixin.ts b/apps/api-extractor-model/src/mixins/ApiItemContainerMixin.ts
@@ -154,7 +154,8 @@ export function ApiItemContainerMixin<TBaseClass extends IApiItemConstructor>(ba
 
     public addMember(member: ApiItem): void {
       if (this[_membersByContainerKey].has(member.containerKey)) {
-        throw new Error('Another member has already been added with the same name and containerKey');
+        throw new Error(`Another member has already been added with the same name (${member.displayName})` +
+          ` and containerKey (${member.containerKey})`);
       }
 
       const existingParent: ApiItem | undefined = member.parent;
diff --git a/common/changes/@microsoft/api-extractor-model/patch-1_2019-10-21-09-12.json b/common/changes/@microsoft/api-extractor-model/patch-1_2019-10-21-09-12.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/api-extractor-model",
+      "comment": "Clarified an error message",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/api-extractor-model",
+  "email": "robin.stevens@scz.be"
+}

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,8 @@ export function ApiItemContainerMixin<TBaseClass extends IApiItemConstructor>(ba`
`154`	`154`
`155`	`155`	`public addMember(member: ApiItem): void {`
`156`	`156`	`if (this[_membersByContainerKey].has(member.containerKey)) {`
`157`		`- throw new Error('Another member has already been added with the same name and containerKey');`
	`157`	+ throw new Error(`Another member has already been added with the same name (${member.displayName})` +
	`158`	+ ` and containerKey (${member.containerKey})`);
`158`	`159`	`}`
`159`	`160`
`160`	`161`	`const existingParent: ApiItem \| undefined = member.parent;`