Fix listener name in NavigationAnimatedView

rclai · Facebook Github Bot 3 · commit ebf5842fe683 · 2016-03-05T15:48:26.000-08:00
Summary:Should be self-explanatory. __Edit__: oh turns out I fixed a memory leak too because of a typo of the typo on teardown. cc ericvicenti Closes facebook/react-native#6309 Differential Revision: D3016576 fb-gh-sync-id: 608a39ad293154e47480003bc9b450b521cddbb1 shipit-source-id: 608a39ad293154e47480003bc9b450b521cddbb1
diff --git a/Libraries/NavigationExperimental/NavigationAnimatedView.js b/Libraries/NavigationExperimental/NavigationAnimatedView.js
@@ -106,7 +106,7 @@ class NavigationAnimatedView
   _animatedWidth: Animated.Value;
   _lastHeight: number;
   _lastWidth: number;
-  _postionListener: any;
+  _positionListener: any;
 
   props: Props;
   state: State;
@@ -129,7 +129,7 @@ class NavigationAnimatedView
     });
   }
   componentDidMount() {
-    this._postionListener = this.state.position.addListener(this._onProgressChange.bind(this));
+    this._positionListener = this.state.position.addListener(this._onProgressChange.bind(this));
   }
   componentWillReceiveProps(nextProps) {
     if (nextProps.navigationState !== this.props.navigationState) {
@@ -144,9 +144,9 @@ class NavigationAnimatedView
     }
   }
   componentWillUnmount() {
-    if (this.postionListener) {
-      this.state.position.removeListener(this._postionListener);
-      this._postionListener = null;
+    if (this._positionListener) {
+      this.state.position.removeListener(this._positionListener);
+      this._positionListener = null;
     }
   }
   _onProgressChange(data: Object): void {

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ class NavigationAnimatedView`
`106`	`106`	`_animatedWidth: Animated.Value;`
`107`	`107`	`_lastHeight: number;`
`108`	`108`	`_lastWidth: number;`
`109`		`- _postionListener: any;`
	`109`	`+ _positionListener: any;`
`110`	`110`
`111`	`111`	`props: Props;`
`112`	`112`	`state: State;`
`@@ -129,7 +129,7 @@ class NavigationAnimatedView`
`129`	`129`	`});`
`130`	`130`	`}`
`131`	`131`	`componentDidMount() {`
`132`		`- this._postionListener = this.state.position.addListener(this._onProgressChange.bind(this));`
	`132`	`+ this._positionListener = this.state.position.addListener(this._onProgressChange.bind(this));`
`133`	`133`	`}`
`134`	`134`	`componentWillReceiveProps(nextProps) {`
`135`	`135`	`if (nextProps.navigationState !== this.props.navigationState) {`
`@@ -144,9 +144,9 @@ class NavigationAnimatedView`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`	`componentWillUnmount() {`
`147`		`- if (this.postionListener) {`
`148`		`- this.state.position.removeListener(this._postionListener);`
`149`		`- this._postionListener = null;`
	`147`	`+ if (this._positionListener) {`
	`148`	`+ this.state.position.removeListener(this._positionListener);`
	`149`	`+ this._positionListener = null;`
`150`	`150`	`}`
`151`	`151`	`}`
`152`	`152`	`_onProgressChange(data: Object): void {`