fix($animate): ensure all comment nodes are removed during a leave animation

matsko · matsko · commit f4f1f43d5140 · 2014-02-26T17:17:41.000-05:00
Closes angular#6403
diff --git a/src/ngAnimate/animate.js b/src/ngAnimate/animate.js
@@ -436,8 +436,7 @@ angular.module('ngAnimate', ['ng'])
           cancelChildAnimations(element);
           this.enabled(false, element);
           $rootScope.$$postDigest(function() {
-            element = stripCommentsFromElement(element);
-            performAnimation('leave', 'ng-leave', element, null, null, function() {
+            performAnimation('leave', 'ng-leave', stripCommentsFromElement(element), null, null, function() {
               $delegate.leave(element);
             }, doneCallback);
           });
diff --git a/test/ngAnimate/animateSpec.js b/test/ngAnimate/animateSpec.js
@@ -3418,6 +3418,27 @@ describe("ngAnimate", function() {
       });
     });
 
+    it('should remove all element and comment nodes during leave animation',
+      inject(function($compile, $rootScope) {
+
+      $rootScope.items = [1,2,3,4,5];
+
+      var element = html($compile(
+        '<div>' +
+        '  <div class="animated" ng-repeat-start="item in items">start</div>' +
+        '  <div ng-repeat-end>end</div>' +
+        '</div>'
+      )($rootScope));
+
+      $rootScope.$digest();
+
+      $rootScope.items = [];
+
+      $rootScope.$digest();
+
+      expect(element.children().length).toBe(0);
+    }));
+
     it('should not throw an error when only comment nodes are rendered in the animation',
       inject(function($rootScope, $compile) {
 
