fix($sniffer): detect transition/animation on older Android browsers

Julien Bouquillon · petebacondarwin · commit ef5bc6c7c333 · 2013-07-03T22:16:31.000+01:00
The stock Android browser doesn't support the current for-in body/style
detection for animations and transitions but we can manually fix this.
This is useful for PhoneGap web-views or traditional web-apps using the
stock browser.
diff --git a/src/ng/sniffer.js b/src/ng/sniffer.js
@@ -37,6 +37,11 @@ function $SnifferProvider() {
       }
       transitions = !!(('transition' in bodyStyle) || (vendorPrefix + 'Transition' in bodyStyle));
       animations  = !!(('animation' in bodyStyle) || (vendorPrefix + 'Animation' in bodyStyle));
+      
+      if (android && (!transitions||!animations)) {
+        transitions = isString(document.body.style.webkitTransition); 
+        animations = isString(document.body.style.webkitAnimation); 
+      }
     }
 
 
diff --git a/test/ng/snifferSpec.js b/test/ng/snifferSpec.js
@@ -179,6 +179,28 @@ describe('$sniffer', function() {
         expect($sniffer.animations).toBe(true);
       });
     });
+
+    it('should be true on android with older body style properties', function() {
+      module(function($provide) {
+        var doc = {
+          body : {
+            style : {
+              webkitAnimation: ''
+            }
+          }
+        };
+        var win = {
+          navigator: {
+            userAgent: 'android 2'
+          }
+        };
+        $provide.value('$document', jqLite(doc));
+        $provide.value('$window', win);
+      });
+      inject(function($sniffer) {
+        expect($sniffer.animations).toBe(true);
+      });
+    });
   });
 
   describe('transitions', function() {
@@ -238,5 +260,27 @@ describe('$sniffer', function() {
       });
     });
 
+    it('should be true on android with older body style properties', function() {
+      module(function($provide) {
+        var doc = {
+          body : {
+            style : {
+              webkitTransition: ''
+            }
+          }
+        };
+        var win = {
+          navigator: {
+            userAgent: 'android 2'
+          }
+        };
+        $provide.value('$document', jqLite(doc));
+        $provide.value('$window', win);
+      });
+      inject(function($sniffer) {
+        expect($sniffer.transitions).toBe(true);
+      });
+    });
+
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,11 @@ function $SnifferProvider() {`
`37`	`37`	`}`
`38`	`38`	`transitions = !!(('transition' in bodyStyle) \|\| (vendorPrefix + 'Transition' in bodyStyle));`
`39`	`39`	`animations = !!(('animation' in bodyStyle) \|\| (vendorPrefix + 'Animation' in bodyStyle));`
	`40`	`+`
	`41`	`+ if (android && (!transitions\|\|!animations)) {`
	`42`	`+ transitions = isString(document.body.style.webkitTransition);`
	`43`	`+ animations = isString(document.body.style.webkitAnimation);`
	`44`	`+ }`
`40`	`45`	`}`
`41`	`46`
`42`	`47`