fix($compile): include non-elements in default transclusion slot

petebacondarwin · petebacondarwin · commit df6fade6e67c · 2015-12-04T13:06:28.000Z
See angular@a4ada8b#commitcomment-14738387
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -1877,7 +1877,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
               });
 
               // Add the matching elements into their slot
-              forEach($compileNode.children(), function(node) {
+              forEach($compileNode.contents(), function(node) {
                 var slotName = slotNames[directiveNormalize(nodeName_(node))];
                 if (slotName) {
                   filledSlots[slotName] = true;
diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
@@ -7714,6 +7714,36 @@ describe('$compile', function() {
       });
     });
 
+
+    it('should include non-element nodes in the default transclusion', function() {
+      module(function() {
+        directive('minionComponent', function() {
+          return {
+            restrict: 'E',
+            scope: {},
+            transclude: {
+              boss: 'bossSlot'
+            },
+            template:
+              '<div class="other" ng-transclude></div>'
+          };
+        });
+      });
+      inject(function($rootScope, $compile) {
+        element = $compile(
+          '<minion-component>' +
+            'text1' +
+            '<span>stuart</span>' +
+            '<span>bob</span>' +
+            '<boss>gru</boss>' +
+            'text2' +
+            '<span>kevin</span>' +
+          '</minion-component>')($rootScope);
+        $rootScope.$apply();
+        expect(element.text()).toEqual('text1stuartbobtext2kevin');
+      });
+    });
+
     it('should transclude elements to an `ng-transclude` with a matching transclusion slot name', function() {
       module(function() {
         directive('minionComponent', function() {
